| Message ID | 1417991502-20223-1-git-send-email-rickard_strandqvist@spectrumdigital.se (mailing list archive) |
|---|---|
| State | Rejected |
| Delegated to: | Michael Ellerman |
| Headers | show |
On Sun, 2014-12-07 at 23:31 +0100, Rickard Strandqvist wrote: > Remove the function cmo_high_show() that is not used anywhere. > > This was partially found by using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> > --- > arch/powerpc/kernel/vio.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/arch/powerpc/kernel/vio.c b/arch/powerpc/kernel/vio.c > index 5bfdab9..11657d2 100644 > --- a/arch/powerpc/kernel/vio.c > +++ b/arch/powerpc/kernel/vio.c > @@ -1032,11 +1032,6 @@ viobus_cmo_pool_rd_attr(reserve, size); > viobus_cmo_pool_rd_attr(excess, size); > viobus_cmo_pool_rd_attr(excess, free); > > -static ssize_t cmo_high_show(struct bus_type *bt, char *buf) > -{ > - return sprintf(buf, "%lu\n", vio_cmo.high); > -} from ../arch/powerpc/kernel/vio.c:17: ../arch/powerpc/kernel/vio.c:1046:20: error: 'cmo_high_show' undeclared here (not in a function) static BUS_ATTR_RW(cmo_high); ^ ../include/linux/sysfs.h:76:10: note: in definition of macro '__ATTR' .show = _show, \ ^ ../include/linux/device.h:53:42: note: in expansion of macro '__ATTR_RW' struct bus_attribute bus_attr_##_name = __ATTR_RW(_name) ^ ../arch/powerpc/kernel/vio.c:1046:8: note: in expansion of macro 'BUS_ATTR_RW' static BUS_ATTR_RW(cmo_high); ^ cheers
diff --git a/arch/powerpc/kernel/vio.c b/arch/powerpc/kernel/vio.c index 5bfdab9..11657d2 100644 --- a/arch/powerpc/kernel/vio.c +++ b/arch/powerpc/kernel/vio.c @@ -1032,11 +1032,6 @@ viobus_cmo_pool_rd_attr(reserve, size); viobus_cmo_pool_rd_attr(excess, size); viobus_cmo_pool_rd_attr(excess, free); -static ssize_t cmo_high_show(struct bus_type *bt, char *buf) -{ - return sprintf(buf, "%lu\n", vio_cmo.high); -} - static ssize_t cmo_high_store(struct bus_type *bt, const char *buf, size_t count) {
Remove the function cmo_high_show() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> --- arch/powerpc/kernel/vio.c | 5 ----- 1 file changed, 5 deletions(-)