From patchwork Sat Mar 8 00:31:32 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joe Perches X-Patchwork-Id: 328129 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from ozlabs.org (localhost [IPv6:::1]) by ozlabs.org (Postfix) with ESMTP id 148822C013A for ; Sat, 8 Mar 2014 11:32:10 +1100 (EST) Received: from smtprelay.hostedemail.com (smtprelay0047.hostedemail.com [216.40.44.47]) by ozlabs.org (Postfix) with ESMTP id D30DE2C00BB for ; Sat, 8 Mar 2014 11:31:37 +1100 (EST) Received: from filter.hostedemail.com (ff-bigip1 [10.5.19.254]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id E88CA9EA25; Sat, 8 Mar 2014 00:31:38 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2, 0, 0, , d41d8cd98f00b204, joe@perches.com, :::::::, RULES_HIT:41:355:379:541:988:989:1260:1261:1277:1311:1313:1314:1345:1373:1437:1515:1516:1518:1534:1539:1568:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3865:3867:3870:3871:5007:7652:7903:10004:10400:10848:11026:11473:11657:11658:11914:12043:12296:12438:12517:12519:12555:13069:13311:13357, 0, RBL:none, CacheIP:none, Bayesian:0.5, 0.5, 0.5, Netcheck:none, DomainCache:0, MSF:not bulk, SPF:fn, MSBL:0, DNSBL:none, Custom_rules:0:0:0 X-HE-Tag: key26_650cb690aa43e X-Filterd-Recvd-Size: 1485 Received: from [192.168.1.157] (pool-96-251-49-11.lsanca.fios.verizon.net [96.251.49.11]) (Authenticated sender: joe@perches.com) by omf05.hostedemail.com (Postfix) with ESMTPA; Sat, 8 Mar 2014 00:31:34 +0000 (UTC) Message-ID: <1394238692.16156.115.camel@joe-AO722> Subject: [PATCH] eeh_pseries: Missing break? From: Joe Perches To: Gavin Shan Date: Fri, 07 Mar 2014 16:31:32 -0800 X-Mailer: Evolution 3.8.4-0ubuntu1 Mime-Version: 1.0 Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" Looks like this is unintentional as the result = EEH_STATE_UNAVAILABLE is being overwritten by EEH_STATE_NOT_SUPPORT in the fallthrough to the default case. Signed-off-by: Joe Perches Acked-by: Gavin Shan diff --git a/arch/powerpc/platforms/pseries/eeh_pseries.c b/arch/powerpc/platforms/pseries/eeh_pseries.c index 8a8f047..83da53f 100644 --- a/arch/powerpc/platforms/pseries/eeh_pseries.c +++ b/arch/powerpc/platforms/pseries/eeh_pseries.c @@ -460,14 +460,15 @@ static int pseries_eeh_get_state(struct eeh_pe *pe, int *state) case 5: if (rets[2]) { if (state) *state = rets[2]; result = EEH_STATE_UNAVAILABLE; } else { result = EEH_STATE_NOT_SUPPORT; } + break; default: result = EEH_STATE_NOT_SUPPORT; } } else { result = EEH_STATE_NOT_SUPPORT; }