| Message ID | 1391674026-20092-1-git-send-email-iamjoonsoo.kim@lge.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On Thu, 6 Feb 2014, Joonsoo Kim wrote: > Currently, if allocation constraint to node is NUMA_NO_NODE, we search > a partial slab on numa_node_id() node. This doesn't work properly on the > system having memoryless node, since it can have no memory on that node and > there must be no partial slab on that node. > > On that node, page allocation always fallback to numa_mem_id() first. So > searching a partial slab on numa_node_id() in that case is proper solution > for memoryless node case. > > Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com> > Acked-by: David Rientjes <rientjes@google.com> I think you'll need to send these to Andrew since he appears to be picking up slub patches these days.
On Thu, 6 Feb 2014, Joonsoo Kim wrote: > Currently, if allocation constraint to node is NUMA_NO_NODE, we search > a partial slab on numa_node_id() node. This doesn't work properly on the > system having memoryless node, since it can have no memory on that node and > there must be no partial slab on that node. > > On that node, page allocation always fallback to numa_mem_id() first. So > searching a partial slab on numa_node_id() in that case is proper solution > for memoryless node case. Acked-by: Christoph Lameter <cl@linux.com>
On Thu, 6 Feb 2014, David Rientjes wrote: > I think you'll need to send these to Andrew since he appears to be picking > up slub patches these days. I can start managing merges again if Pekka no longer has the time.
On 06.02.2014 [17:07:04 +0900], Joonsoo Kim wrote: > Currently, if allocation constraint to node is NUMA_NO_NODE, we search > a partial slab on numa_node_id() node. This doesn't work properly on the > system having memoryless node, since it can have no memory on that node and > there must be no partial slab on that node. > > On that node, page allocation always fallback to numa_mem_id() first. So > searching a partial slab on numa_node_id() in that case is proper solution > for memoryless node case. > > Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com> Acked-by: Nishanth Aravamudan <nacc@linux.vnet.ibm.com> Joonsoo, would you send this one on to Andrew? Thanks, Nish
On Fri, May 16, 2014 at 04:37:35PM -0700, Nishanth Aravamudan wrote: > On 06.02.2014 [17:07:04 +0900], Joonsoo Kim wrote: > > Currently, if allocation constraint to node is NUMA_NO_NODE, we search > > a partial slab on numa_node_id() node. This doesn't work properly on the > > system having memoryless node, since it can have no memory on that node and > > there must be no partial slab on that node. > > > > On that node, page allocation always fallback to numa_mem_id() first. So > > searching a partial slab on numa_node_id() in that case is proper solution > > for memoryless node case. > > > > Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com> > > Acked-by: Nishanth Aravamudan <nacc@linux.vnet.ibm.com> > > Joonsoo, would you send this one on to Andrew? Hello, Okay. I will do it. Thanks.
On Wed, 21 May 2014, Joonsoo Kim wrote: > Currently, if allocation constraint to node is NUMA_NO_NODE, we search > a partial slab on numa_node_id() node. This doesn't work properly on the > system having memoryless node, since it can have no memory on that node and > there must be no partial slab on that node. > > On that node, page allocation always fallback to numa_mem_id() first. So > searching a partial slab on numa_node_id() in that case is proper solution > for memoryless node case. > > Acked-by: Nishanth Aravamudan <nacc@linux.vnet.ibm.com> > Acked-by: David Rientjes <rientjes@google.com> > Acked-by: Christoph Lameter <cl@linux.com> > Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com> > > diff --git a/mm/slub.c b/mm/slub.c > index 545a170..cc1f995 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -1698,7 +1698,7 @@ static void *get_partial(struct kmem_cache *s, gfp_t flags, int node, > struct kmem_cache_cpu *c) > { > void *object; > - int searchnode = (node == NUMA_NO_NODE) ? numa_node_id() : node; > + int searchnode = (node == NUMA_NO_NODE) ? numa_mem_id() : node; > > object = get_partial_node(s, get_node(s, searchnode), c, flags); > if (object || node != NUMA_NO_NODE) Andrew, can you merge this please? It's still not in linux-next.
diff --git a/mm/slub.c b/mm/slub.c index 545a170..cc1f995 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -1698,7 +1698,7 @@ static void *get_partial(struct kmem_cache *s, gfp_t flags, int node, struct kmem_cache_cpu *c) { void *object; - int searchnode = (node == NUMA_NO_NODE) ? numa_node_id() : node; + int searchnode = (node == NUMA_NO_NODE) ? numa_mem_id() : node; object = get_partial_node(s, get_node(s, searchnode), c, flags); if (object || node != NUMA_NO_NODE)
Currently, if allocation constraint to node is NUMA_NO_NODE, we search a partial slab on numa_node_id() node. This doesn't work properly on the system having memoryless node, since it can have no memory on that node and there must be no partial slab on that node. On that node, page allocation always fallback to numa_mem_id() first. So searching a partial slab on numa_node_id() in that case is proper solution for memoryless node case. Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>