| Message ID | 1366193026-20871-1-git-send-email-Shengzhou.Liu@freescale.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Wed, 17 Apr 2013, Shengzhou Liu wrote: > We remove the redundant tdi_reset in ehci_setup since there > is already it in ehci_reset. > It was observed that the duplicated tdi_reset was causing > the PHY_CLK_VALID bit unstable. > > Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com> > --- > drivers/usb/host/ehci-hcd.c | 3 --- > 1 files changed, 0 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c > index 416a6dc..83b5a17 100644 > --- a/drivers/usb/host/ehci-hcd.c > +++ b/drivers/usb/host/ehci-hcd.c > @@ -670,9 +670,6 @@ int ehci_setup(struct usb_hcd *hcd) > if (retval) > return retval; > > - if (ehci_is_TDI(ehci)) > - tdi_reset(ehci); > - > ehci_reset(ehci); > > return 0; Acked-by: Alan Stern <stern@rowland.harvard.edu> This should be applied to stable kernels going back to 3.6. In case you are wondering why that redudant call was added, I did it because some of the PCI drivers (Intel and TDI) already had calls to tdi_reset. The commit removed those calls, so the new one was added in.
diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c index 416a6dc..83b5a17 100644 --- a/drivers/usb/host/ehci-hcd.c +++ b/drivers/usb/host/ehci-hcd.c @@ -670,9 +670,6 @@ int ehci_setup(struct usb_hcd *hcd) if (retval) return retval; - if (ehci_is_TDI(ehci)) - tdi_reset(ehci); - ehci_reset(ehci); return 0;
We remove the redundant tdi_reset in ehci_setup since there is already it in ehci_reset. It was observed that the duplicated tdi_reset was causing the PHY_CLK_VALID bit unstable. Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com> --- drivers/usb/host/ehci-hcd.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-)