| Message ID | 152836568375.29173.3046879842311381046.stgit@jupiter.in.ibm.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | powerpc/pseries: Machien check handler improvements. | expand |
On Thu, 07 Jun 2018 15:36:25 +0530 Mahesh J Salgaonkar <mahesh@linux.vnet.ibm.com> wrote: > This patch series includes some improvement to Machine check handler > for pseries. Patch 1 fixes an issue where machine check handler crashes > kernel while accessing vmalloc-ed buffer while in nmi context. > Patch 3 dumps the SLB contents on SLB MCE errors to improve the debugability. > Patch 4 display's the MCE error details on console. > > Change in V2: > - patch 4: Display additional info (NIP and task info) in MCE error details. > - patch 5: Fix endain bug while restoring of r3 in MCE handler. > > --- > > Mahesh Salgaonkar (5): > powerpc/pseries: convert rtas_log_buf to linear allocation. > powerpc/pseries: Define MCE error event section. > powerpc/pseries: Dump and flush SLB contents on SLB MCE errors. > powerpc/pseries: Display machine check error details. > powerpc/pseries: Fix endainness while restoring of r3 in MCE handler. These look good, should patch 5 be moved to patch 2 and the first 2 patches marked for stable? Do you also plan to dump SLB contents for bare metal MCEs? Thanks, Nick
On 06/07/2018 04:15 PM, Nicholas Piggin wrote: > On Thu, 07 Jun 2018 15:36:25 +0530 > Mahesh J Salgaonkar <mahesh@linux.vnet.ibm.com> wrote: > >> This patch series includes some improvement to Machine check handler >> for pseries. Patch 1 fixes an issue where machine check handler crashes >> kernel while accessing vmalloc-ed buffer while in nmi context. >> Patch 3 dumps the SLB contents on SLB MCE errors to improve the debugability. >> Patch 4 display's the MCE error details on console. >> >> Change in V2: >> - patch 4: Display additional info (NIP and task info) in MCE error details. >> - patch 5: Fix endain bug while restoring of r3 in MCE handler. >> >> --- >> >> Mahesh Salgaonkar (5): >> powerpc/pseries: convert rtas_log_buf to linear allocation. >> powerpc/pseries: Define MCE error event section. >> powerpc/pseries: Dump and flush SLB contents on SLB MCE errors. >> powerpc/pseries: Display machine check error details. >> powerpc/pseries: Fix endainness while restoring of r3 in MCE handler. > > These look good, should patch 5 be moved to patch 2 and the first 2 > patches marked for stable? Yup. Will move patch 5 to 2nd position. > > Do you also plan to dump SLB contents for bare metal MCEs? Yes. That's the plan. Will do that separately. Thanks, -Mahesh.
This patch series includes some improvement to Machine check handler for pseries. Patch 1 fixes an issue where machine check handler crashes kernel while accessing vmalloc-ed buffer while in nmi context. Patch 3 dumps the SLB contents on SLB MCE errors to improve the debugability. Patch 4 display's the MCE error details on console. Change in V2: - patch 4: Display additional info (NIP and task info) in MCE error details. - patch 5: Fix endain bug while restoring of r3 in MCE handler. --- Mahesh Salgaonkar (5): powerpc/pseries: convert rtas_log_buf to linear allocation. powerpc/pseries: Define MCE error event section. powerpc/pseries: Dump and flush SLB contents on SLB MCE errors. powerpc/pseries: Display machine check error details. powerpc/pseries: Fix endainness while restoring of r3 in MCE handler. arch/powerpc/include/asm/book3s/64/mmu-hash.h | 1 arch/powerpc/include/asm/rtas.h | 109 ++++++++++++++++++ arch/powerpc/kernel/rtasd.c | 2 arch/powerpc/mm/slb.c | 35 ++++++ arch/powerpc/platforms/pseries/ras.c | 155 +++++++++++++++++++++++++ 5 files changed, 299 insertions(+), 3 deletions(-) -- Signature