Message ID | aBxyDyVT5QbOlhPq@gmail.com |
---|---|
State | Handled Elsewhere |
Headers | show |
Series | [-v2] accel/habanalabs: Don't build the driver on UML | expand |
On Thu, 2025-05-08 at 10:57 +0200, Ingo Molnar wrote: > > > > I dunno. I guess we can put rdtsc() into UML on x86 as I suggested about > > the file placement, or we can also just fix the Kconfig there. > > The Kconfig solution looks much simpler to me too :) > > Patch attached, does this look good to you? Yeah looks good to me. Common gotcha really. Reviewed-by: Johannes Berg <johannes@sipsolutions.net> If anyone _really_ needs to have this driver built on UML (say for simulations/testing, we do build iwlwifi for all the time), then they'd probably want to replace the rdtsc() anyway with something else there. johannes
* Johannes Berg <johannes@sipsolutions.net> wrote: > On Thu, 2025-05-08 at 10:57 +0200, Ingo Molnar wrote: > > > > > > I dunno. I guess we can put rdtsc() into UML on x86 as I suggested about > > > the file placement, or we can also just fix the Kconfig there. > > > > The Kconfig solution looks much simpler to me too :) > > > > Patch attached, does this look good to you? > > Yeah looks good to me. Common gotcha really. > > Reviewed-by: Johannes Berg <johannes@sipsolutions.net> Thanks, applied to tip:x86/msr. > If anyone _really_ needs to have this driver built on UML (say for > simulations/testing, we do build iwlwifi for all the time), then > they'd probably want to replace the rdtsc() anyway with something > else there. Yeah. Ingo
diff --git a/drivers/accel/habanalabs/Kconfig b/drivers/accel/habanalabs/Kconfig index be85336107f9..1919fbb169c7 100644 --- a/drivers/accel/habanalabs/Kconfig +++ b/drivers/accel/habanalabs/Kconfig @@ -6,7 +6,7 @@ config DRM_ACCEL_HABANALABS tristate "HabanaLabs AI accelerators" depends on DRM_ACCEL - depends on X86_64 + depends on X86 && X86_64 depends on PCI && HAS_IOMEM select GENERIC_ALLOCATOR select HWMON