| Message ID | 20251121-printk-cleanup-part2-v2-1-57b8b78647f4@suse.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | printk cleanup - part 2 | expand |
On Fri 2025-11-21 15:50:33, Marcos Paulo de Souza wrote: > The original code tried to find a console that has CON_BOOT _or_ > CON_ENABLED flag set. The flag CON_ENABLED is set to all registered > consoles, so in this case this check is always true, even for the > CON_BOOT consoles. > > The initial intent of the kgdboc_earlycon_init was to get a console > early (CON_BOOT) or later on in the process (CON_ENABLED). The > code was using for_each_console macro, meaning that all console structs > were previously registered on the printk() machinery. At this point, > any console found on for_each_console is safe for kgdboc_earlycon_init > to use. > > Dropping the check makes the code cleaner, and avoids further confusion > by future readers of the code. > > Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com> I agree that the check is superfluous and can be removed: Reviewed-by: Petr Mladek <pmladek@suse.com> Best Regards, Petr
diff --git a/drivers/tty/serial/kgdboc.c b/drivers/tty/serial/kgdboc.c index 85f6c5a76e0f..5a955c80a853 100644 --- a/drivers/tty/serial/kgdboc.c +++ b/drivers/tty/serial/kgdboc.c @@ -577,7 +577,6 @@ static int __init kgdboc_earlycon_init(char *opt) console_list_lock(); for_each_console(con) { if (con->write && con->read && - (con->flags & (CON_BOOT | CON_ENABLED)) && (!opt || !opt[0] || strcmp(con->name, opt) == 0)) break; }
The original code tried to find a console that has CON_BOOT _or_ CON_ENABLED flag set. The flag CON_ENABLED is set to all registered consoles, so in this case this check is always true, even for the CON_BOOT consoles. The initial intent of the kgdboc_earlycon_init was to get a console early (CON_BOOT) or later on in the process (CON_ENABLED). The code was using for_each_console macro, meaning that all console structs were previously registered on the printk() machinery. At this point, any console found on for_each_console is safe for kgdboc_earlycon_init to use. Dropping the check makes the code cleaner, and avoids further confusion by future readers of the code. Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com> --- drivers/tty/serial/kgdboc.c | 1 - 1 file changed, 1 deletion(-)