[v3,01/12] tools compiler.h: fix __used definition

Message ID	20250924142059.527768-2-benjamin@sipsolutions.net
State	Changes Requested
Headers	show Return-Path: <linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> From: Benjamin Berg <benjamin@sipsolutions.net> To: linux-um@lists.infradead.org, Willy Tarreau <w@1wt.eu>, =?utf-8?q?Thomas?= =?utf-8?q?_Wei=C3=9Fschuh?= <linux@weissschuh.net>, linux-kselftest@vger.kernel.org, Arnaldo Carvalho de Melo <acme@redhat.com> Cc: linux-kernel@vger.kernel.org, Benjamin Berg <benjamin.berg@intel.com> Subject: [PATCH v3 01/12] tools compiler.h: fix __used definition Date: Wed, 24 Sep 2025 16:20:48 +0200 Message-ID: <20250924142059.527768-2-benjamin@sipsolutions.net> In-Reply-To: <20250924142059.527768-1-benjamin@sipsolutions.net> References: <20250924142059.527768-1-benjamin@sipsolutions.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit preview: From: Benjamin Berg <benjamin.berg@intel.com> The define mapped to __attribute__((__unused__)) instead of using __used__. Having the wrong definition here may result in the linker incorrectly removing the symbol. Also, this now matches the defini [...] Content analysis details: (-2.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Precedence: list Sender: "linux-um" <linux-um-bounces@lists.infradead.org> Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org
Series	Start porting UML to nolibc \| expand [v3,00/12] Start porting UML to nolibc [v3,01/12] tools compiler.h: fix __used definition [v3,02/12] um: use tools/include for user files [v3,03/12] tools/nolibc/stdio: let perror work when NOLIBC_IGNORE_ERRNO is set [v3,04/12] tools/nolibc/dirent: avoid errno in readdir_r [v3,05/12] tools/nolibc: implement %m if errno is not defined [v3,06/12] tools/nolibc: use __fallthrough__ rather than fallthrough [v3,07/12] tools/nolibc: add option to disable runtime [v3,08/12] um: add infrastructure to build files using nolibc [v3,09/12] um: use nolibc for the --showconfig implementation [v3,10/12] tools/nolibc: add uio.h with readv and writev [v3,11/12] tools/nolibc: add ptrace support [v3,12/12] um: switch ptrace FP register access to nolibc

Message ID

20250924142059.527768-2-benjamin@sipsolutions.net

State

Changes Requested

Headers

From: Benjamin Berg <benjamin@sipsolutions.net>
To: linux-um@lists.infradead.org, Willy Tarreau <w@1wt.eu>, =?utf-8?q?Thomas?=
	=?utf-8?q?_Wei=C3=9Fschuh?= <linux@weissschuh.net>,
 linux-kselftest@vger.kernel.org, Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: linux-kernel@vger.kernel.org,
	Benjamin Berg <benjamin.berg@intel.com>
Subject: [PATCH v3 01/12] tools compiler.h: fix __used definition
Date: Wed, 24 Sep 2025 16:20:48 +0200
Message-ID: <20250924142059.527768-2-benjamin@sipsolutions.net>
In-Reply-To: <20250924142059.527768-1-benjamin@sipsolutions.net>
References: <20250924142059.527768-1-benjamin@sipsolutions.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: list
Sender: "linux-um" <linux-um-bounces@lists.infradead.org>
Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org

Series

Start porting UML to nolibc | expand

Commit Message

Benjamin Berg Sept. 24, 2025, 2:20 p.m. UTC

From: Benjamin Berg <benjamin.berg@intel.com>

The define mapped to __attribute__((__unused__)) instead of using
__used__. Having the wrong definition here may result in the linker
incorrectly removing the symbol. Also, this now matches the definition
in include/linux/compiler_attributes.h.

Fixes: e58e871becec ("tools/lib/lockdep: Remove private kernel headers")
Signed-off-by: Benjamin Berg <benjamin.berg@intel.com>
Reviewed-by: Thomas Weißschuh <linux@weissschuh.net>
---
 tools/include/linux/compiler.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/include/linux/compiler.h b/tools/include/linux/compiler.h
index 33411ca0cc90..b2c40621d441 100644
--- a/tools/include/linux/compiler.h
+++ b/tools/include/linux/compiler.h
@@ -127,7 +127,7 @@ 
 #endif
 
 #ifndef __used
-# define __used		__attribute__((__unused__))
+# define __used		__attribute__((__used__))
 #endif
 
 #ifndef __packed

[v3,01/12] tools compiler.h: fix __used definition

Commit Message

Patch