Message ID | 20240327-module-owner-virtio-v1-2-0feffab77d99@linaro.org |
---|---|
State | Not Applicable |
Headers | show
Return-Path: <linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=sWOioVk8; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Jl4hOqxH; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4V4RBw3LgMz1yWr for <incoming@patchwork.ozlabs.org>; Wed, 27 Mar 2024 23:42:16 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Z2N77S+83trKseWxbTwOaTLrIYXxobuVp9FyL/kFGQQ=; b=sWOioVk8EZMMIiZ0N8PM7ytCWm ehTTS9DThtvsA0gX9PzPjfupfl4PAPyGNgAKgQeQs5iR/dYuixLPn4F5C25dEnQxYlEyfVxcI6+EC HQqbML+0VJijt+Vf1y+dpb2sDJhCZLZfpPu1wXzu+cVi30zuqveXJGj0UQnGq0Jtm81a782ZrRKUA GGfs7GpntqvicOc8y0Xdhmt3wBZr4oj3trescMoUkYR3t0W7KflOzWE/Vau/pQP0oEPFMwFz1bCku svyL6Gd0FYFx4fj493sWxqRUOBXTPQBiAZBLWsjcBLiDVNvGGbJ5b6XXSZgcBV5cPJ5V/6rpc6g00 tiQlfAmQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpSbe-00000008xG7-1kux; Wed, 27 Mar 2024 12:42:14 +0000 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpSba-00000008xCk-3Iyv for linux-um@lists.infradead.org; Wed, 27 Mar 2024 12:42:12 +0000 Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-a2f22bfb4e6so882215966b.0 for <linux-um@lists.infradead.org>; Wed, 27 Mar 2024 05:42:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711543328; x=1712148128; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Z2N77S+83trKseWxbTwOaTLrIYXxobuVp9FyL/kFGQQ=; b=Jl4hOqxHwh2Xpt+EIKAGZyLDd8kWHPK0Mi5/6wvZP4vY15UloOxK9/UIyzUWKNbHK6 RRYRsXkfR8vrb0ZRZq0oM+X4xi8tiy6ryJbaGUMEdjzzd8PcUyO4LEDQwtEr+VrX7Sty V9B9fBqLJNGSshjjWdEJXwSbpPaByhuALAxcffx9m3c5V6sBfbCvEXiqSuUAWJnashhm t3Ie8c7MIUK8/DR5sMXtgv0TJzQvRNileLQqbH2GIIlcmgTPO+CrmEpgp9+mwO8bt0EA h1Q6VqMsGGTrmGHPybFDO3om05Qo87qqsmuZyjqmnNLPSXuSIaKSFR0c86xgZsW5Dw5L 5F8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711543328; x=1712148128; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Z2N77S+83trKseWxbTwOaTLrIYXxobuVp9FyL/kFGQQ=; b=Vz/hAIv+dSApWnz3o9jgxaw28BAwwg0/jlRvhlTnArxacmGUiLElEC761P9h2MPzB2 Wtp2uXVSjr7XexiMdCigsNST8wKDO08IAEBrFk352JiGRpB7+kuHZXpmXTJmR3XBQKCn 4XnQp0NSxA+F1fhFfemV0MjGglA1MYZ8+4e1eEfhXjz3xXMNjLX5hRdBgKxtte3l8PAm ED/LuYWfTRACiqvDuYPSBXEu8PMsAMkITOKZMm9mDVSiM5QH6B/4YS3Qfzm9LoB6nIEd kF3rCdFlVoTxKEtwlJz/Qb03MAHjcgiiK7/hqYI+q8idrL50e7KooCgGiRDbNfBRHGTa uA6g== X-Forwarded-Encrypted: i=1; AJvYcCVnl+W3sUvHeTvdwwXYSP1ivLeAJYp13LceC2D60Wh9Lkhb/4VnLr/euilXwTGtUMnFJGXTRy687C1RvpgQ5kII/Iti8mYu/XazFbxf X-Gm-Message-State: AOJu0YxKAcjh/jwP41LV4hQH/5uAC76MH+VGTQqAK/0bmKbwDyN5JZv4 1qPZf3/VkmCxcGzyBTuHHeexTLoO8/Q5i5hT5eqEhrKMoZ87iIwjGRKzR5tbFf0= X-Google-Smtp-Source: AGHT+IEkE4pNot1uzWqq/Dxu/KgO4mLE7QfsgLYuIObS5ATO5treG1hWzzYXKuUBzpsw7NHEclpATw== X-Received: by 2002:a17:906:718f:b0:a47:47fc:441e with SMTP id h15-20020a170906718f00b00a4747fc441emr836212ejk.47.1711543328069; Wed, 27 Mar 2024 05:42:08 -0700 (PDT) Received: from [127.0.1.1] ([178.197.206.205]) by smtp.gmail.com with ESMTPSA id gx16-20020a170906f1d000b00a4707ec7c34sm5379175ejb.166.2024.03.27.05.41.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 05:42:07 -0700 (PDT) From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Date: Wed, 27 Mar 2024 13:40:55 +0100 Subject: [PATCH 02/22] um: virt-pci: drop owner assignment MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240327-module-owner-virtio-v1-2-0feffab77d99@linaro.org> References: <20240327-module-owner-virtio-v1-0-0feffab77d99@linaro.org> In-Reply-To: <20240327-module-owner-virtio-v1-0-0feffab77d99@linaro.org> To: "Michael S. Tsirkin" <mst@redhat.com>, Jason Wang <jasowang@redhat.com>, Xuan Zhuo <xuanzhuo@linux.alibaba.com>, Richard Weinberger <richard@nod.at>, Anton Ivanov <anton.ivanov@cambridgegreys.com>, Johannes Berg <johannes@sipsolutions.net>, Paolo Bonzini <pbonzini@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Jens Axboe <axboe@kernel.dk>, Marcel Holtmann <marcel@holtmann.org>, Luiz Augusto von Dentz <luiz.dentz@gmail.com>, Olivia Mackall <olivia@selenic.com>, Herbert Xu <herbert@gondor.apana.org.au>, Amit Shah <amit@kernel.org>, Arnd Bergmann <arnd@arndb.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Gonglei <arei.gonglei@huawei.com>, "David S. Miller" <davem@davemloft.net>, Viresh Kumar <vireshk@kernel.org>, Linus Walleij <linus.walleij@linaro.org>, Bartosz Golaszewski <brgl@bgdev.pl>, David Airlie <airlied@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, Gurchetan Singh <gurchetansingh@chromium.org>, Chia-I Wu <olvaffe@gmail.com>, Jean-Philippe Brucker <jean-philippe@linaro.org>, Joerg Roedel <joro@8bytes.org>, Alexander Graf <graf@amazon.com>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Eric Van Hensbergen <ericvh@kernel.org>, Latchesar Ionkov <lucho@ionkov.net>, Dominique Martinet <asmadeus@codewreck.org>, Christian Schoenebeck <linux_oss@crudebyte.com>, Stefano Garzarella <sgarzare@redhat.com>, Kalle Valo <kvalo@kernel.org>, Dan Williams <dan.j.williams@intel.com>, Vishal Verma <vishal.l.verma@intel.com>, Dave Jiang <dave.jiang@intel.com>, Ira Weiny <ira.weiny@intel.com>, Pankaj Gupta <pankaj.gupta.linux@gmail.com>, Bjorn Andersson <andersson@kernel.org>, Mathieu Poirier <mathieu.poirier@linaro.org>, "Martin K. Petersen" <martin.petersen@oracle.com>, Vivek Goyal <vgoyal@redhat.com>, Miklos Szeredi <miklos@szeredi.hu>, Anton Yakovlev <anton.yakovlev@opensynergy.com>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com> Cc: virtualization@lists.linux.dev, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-um@lists.infradead.org, linux-block@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, dri-devel@lists.freedesktop.org, iommu@lists.linux.dev, netdev@vger.kernel.org, v9fs@lists.linux.dev, kvm@vger.kernel.org, linux-wireless@vger.kernel.org, nvdimm@lists.linux.dev, linux-remoteproc@vger.kernel.org, linux-scsi@vger.kernel.org, linux-fsdevel@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=718; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=i29GGpteKXJOT7Y7HQVb9d3eZ/9hZZ41eKapONuqqTs=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBmBBPbywJQXZioM2grDNH1GhnbC9jT7FlHBu8Il BXxYGwRjraJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZgQT2wAKCRDBN2bmhouD 141rD/4uo4AQiIOCl21dlkWWoVLjNoCmALlYeYWtYXDJLeS9+PR/4c2YDTN11rNGZIY/nuXht+R 08R2mFazQGyBslNrJRa5JhTm27rGZioRY5wiYiHqxItX9wtbLBAaPUS9Nophm+R4wqOUhsZnpH2 iXQpVZU+WxzXQWPWb37iMmYzasbeW4glBRKXiiC3CiF8u0wRyTUDts0V602SqlnsxNufaQ8Fhkw v2BkNkkV2fb7XDmngW8OJ0kdV0Jyz61GQTc1t+4KdTLSlm4BqGSDVopNAVcuGaanCqBF/52q9Vw GwfqQB77dn2XOgo/ZR0RSXAr23vu/0OwanIMUXPmNtLP0HdBjsPDci1Vl6eBKtREXmXYWwbZZYz CWS0C80pM9J/VlR5mCSMck3fBmEeDTvE8F9MpZEre2yc2Q29DVx/bpfm6ztE/EyVr0F9Up8O/Tr VA6FaMUz1KovyBRE8weaVHwCZ12Ab+SEc/U7hZ50L35WTjMLlYVRdlVUmcIzP2KmiQnV3W6jpMz orbUL5s/p8br6ozoNcPu5ZcZz+mLi4MpfFyp/6zJ+ciMyf/3IUkaehDBf8Q36omx98PhwP8KxB6 /565K/p5SNWNrrGqH3SAriemyZe8lv2MhxVq7qZ+7WqhhglZ3FWLG0w1uleUDxPVaxFkVFtntn7 qgSaAlhyRZ+9xPg== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240327_054210_980797_968B2688 X-CRM114-Status: GOOD ( 11.42 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: virtio core already sets the .owner, so driver does not need to. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:62c listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: <linux-um.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-um>, <mailto:linux-um-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-um/> List-Post: <mailto:linux-um@lists.infradead.org> List-Help: <mailto:linux-um-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-um>, <mailto:linux-um-request@lists.infradead.org?subject=subscribe> Sender: "linux-um" <linux-um-bounces@lists.infradead.org> Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org |
Series |
virtio: store owner from modules with register_virtio_driver()
|
expand
|
On Wed, 2024-03-27 at 13:40 +0100, Krzysztof Kozlowski wrote: > virtio core already sets the .owner, so driver does not need to. > All further patches depend on the first virtio patch, therefore please ack > and this should go via one tree: virtio? Sure. Though it's not really actually necessary, you can set it in the core and merge the other patches in the next cycle; those drivers that _have_ an .owner aren't broken after all. Acked-by: Johannes Berg <johannes@sipsolutions.net> johannes
On 27/03/2024 14:34, Johannes Berg wrote: > On Wed, 2024-03-27 at 13:40 +0100, Krzysztof Kozlowski wrote: >> virtio core already sets the .owner, so driver does not need to. > >> All further patches depend on the first virtio patch, therefore please ack >> and this should go via one tree: virtio? > > Sure. Though it's not really actually necessary, you can set it in the > core and merge the other patches in the next cycle; those drivers that > _have_ an .owner aren't broken after all. > > Acked-by: Johannes Berg <johannes@sipsolutions.net> True, this can be spread over two cycles. What I wanted to express, is that maintainers should not pick individual patches. Thanks for the Ack and apologies for a bit too big CC-list. I need to learn how to ask b4 to make Cc-per-patch for such case. Best regards, Krzysztof
diff --git a/arch/um/drivers/virt-pci.c b/arch/um/drivers/virt-pci.c index 97a37c062997..7cb503469bbd 100644 --- a/arch/um/drivers/virt-pci.c +++ b/arch/um/drivers/virt-pci.c @@ -752,7 +752,6 @@ MODULE_DEVICE_TABLE(virtio, id_table); static struct virtio_driver um_pci_virtio_driver = { .driver.name = "virtio-pci", - .driver.owner = THIS_MODULE, .id_table = id_table, .probe = um_pci_virtio_probe, .remove = um_pci_virtio_remove,
virtio core already sets the .owner, so driver does not need to. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Depends on the first patch. --- arch/um/drivers/virt-pci.c | 1 - 1 file changed, 1 deletion(-)