Message ID | 20210828011108.11232-1-deng.changcheng@zte.com.cn |
---|---|
State | Accepted |
Headers | show
Return-Path: <linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=zA57sv90; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=otEH4Zf3; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GxJSg3W0Gz9sSn for <incoming@patchwork.ozlabs.org>; Sat, 28 Aug 2021 11:11:31 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=88u/+yBH295xWklnKm9Yv2KyJ1SKi/Se1YCghbKd4z8=; b=zA57sv90Yvum8z pe42Vt3EyXyyiqxnlUNj5WBaA5os2/FKA9LTq+yY/0HVZgOiRGY2bcQVh9bMLhflNjOozlo2HCLLX dZRI/4Q5de2hDNGmXbmxI8ToU6CFpYcbQOcW/DD2fg5T2DYDEou+vulMYjZPT926UMhyrbCS5ZnXr rqfV5Ma1xcGiGTD94loFMIF2xifGeR9CWtc9w+SrY7acqmSv7Rxh4+DIsmJGFdvmOoyjfANfVTk1u teF/tZ+JKAQhWvX95gHxsfzRluc0qdKFnLJslDqwzAuXM1ezOM2pOxhnxVmRXr39CXZF2mHp/xwBn UTdxoKVQpE/k054s4UIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mJmsS-00DZ7e-BB; Sat, 28 Aug 2021 01:11:20 +0000 Received: from mail-qt1-x82e.google.com ([2607:f8b0:4864:20::82e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mJmsQ-00DZ6s-AG for linux-um@lists.infradead.org; Sat, 28 Aug 2021 01:11:19 +0000 Received: by mail-qt1-x82e.google.com with SMTP id r21so6786835qtw.11 for <linux-um@lists.infradead.org>; Fri, 27 Aug 2021 18:11:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=jbKjJi+SjlBlvBWeuYSN6P3GgzXQjaFRsk5Xet0fqF4=; b=otEH4Zf3r/yrdw9fwNxLDZFbEn2KbGIc1rnCbtRcunDXhwOxyooauliDHc4vQ3vM5R poWfKM5LepAL+e8+WgwObuhWn/Jm8NgGKEFSq/nKDJzWr7V6oBzXRIwXRsnXP36zwqPX 09OM6mAvBfhQnv0WQ59X+Ba5Hvle2A3OYtDiTRrUhLDPt3n8dILsRigiV3DBnG00PoJ0 d76Vvvb9U89Lax8Q6DNzE/Eykw5slTbCZLYUdnr6FqEL0OavkpXVr+9niREO0PnU7dpG YjGt52HwHk8YndxBx7IiK28sXT0XBsLqzLsA+/0zXlwhGRnvyYmTsAxY/BgEmxGqBroh twEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=jbKjJi+SjlBlvBWeuYSN6P3GgzXQjaFRsk5Xet0fqF4=; b=KY//vUYOUsmugAUTo5ePXxJ29rnydtlKDr82S8ByJBf6E6xWmkSwwALP+g4Qr0vrvo TsKP0xV2dWCNb45ha8hfZslBxEYBDwtoYq7GKehXZCjj2WkZc/KB/51fMf7IPEvFwnXw 4Exxn5G7NvNclQ05FQMDkaSHm0u2aWH4ZqKEH1kb4gEVeKb4cHBYYRCaTcn8vRpqVv8P hhAdWFmGYbIhF0Smy1FcMsWQa0tAm9hWzkkyt0LO4Uf2TbCmcZX2Iz9YG42ypsvh7eNh zYHqp+hhoV0oA6Sz6IPW67d3MdccuuffQlQo8NifyZWDfJq3mI8uLTaBpEMvwO5iYxBP CfJQ== X-Gm-Message-State: AOAM532t2xo9yfjOsJFman1D2tzF9k5HDFhALz0mIvfzBTf8+dZKx5jN llcbbrduaa9mcFQReN91HsBBiGAjUxo= X-Google-Smtp-Source: ABdhPJwIwrrPhRFtDeJwcwFAYL0p4jwDMGhBkLRQedTlZTJESvAvn/2GegNe/WfdH9vRVWQnc2RXsw== X-Received: by 2002:aed:304c:: with SMTP id 70mr11104623qte.2.1630113076555; Fri, 27 Aug 2021 18:11:16 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id w14sm6069193qkm.81.2021.08.27.18.11.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Aug 2021 18:11:16 -0700 (PDT) From: CGEL <cgel.zte@gmail.com> X-Google-Original-From: CGEL <deng.changcheng@zte.com.cn> To: Jeff Dike <jdike@addtoit.com> Cc: Richard Weinberger <richard@nod.at>, Anton Ivanov <anton.ivanov@cambridgegreys.com>, Andrew Morton <akpm@linux-foundation.org>, David Hildenbrand <david@redhat.com>, Yang Li <yang.lee@linux.alibaba.com>, Christophe Leroy <christophe.leroy@c-s.fr>, Dave Hansen <dave.hansen@linux.intel.com>, Kefeng Wang <wangkefeng.wang@huawei.com>, linux-um@lists.infradead.org, linux-kernel@vger.kernel.org, Changcheng Deng <deng.changcheng@zte.com.cn>, Zeal Robot <zealci@zte.com.cn> Subject: [PATCH linux-next] um: Replace if (cond) BUG() with BUG_ON() Date: Fri, 27 Aug 2021 18:11:08 -0700 Message-Id: <20210828011108.11232-1-deng.changcheng@zte.com.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210827_181118_418041_068D5DB0 X-CRM114-Status: GOOD ( 10.08 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Changcheng Deng Fix the following coccinelle reports: ./arch/um/kernel/mem.c:89:2-5: WARNING: Use BUG_ON instead of if condition followed by BUG. Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:82e listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [cgel.zte[at]gmail.com] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: <linux-um.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-um>, <mailto:linux-um-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-um/> List-Post: <mailto:linux-um@lists.infradead.org> List-Help: <mailto:linux-um-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-um>, <mailto:linux-um-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" <linux-um-bounces@lists.infradead.org> Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org |
Series |
[linux-next] um: Replace if (cond) BUG() with BUG_ON()
|
expand
|
diff --git a/arch/um/kernel/mem.c b/arch/um/kernel/mem.c index 8e636ce..1810e69 100644 --- a/arch/um/kernel/mem.c +++ b/arch/um/kernel/mem.c @@ -85,8 +85,7 @@ static void __init one_md_table_init(pud_t *pud) __func__, PAGE_SIZE, PAGE_SIZE); set_pud(pud, __pud(_KERNPG_TABLE + (unsigned long) __pa(pmd_table))); - if (pmd_table != pmd_offset(pud, 0)) - BUG(); + BUG_ON(pmd_table != pmd_offset(pud, 0)); #endif }