diff mbox series

[1/4] um: make PCI emulation driver init/exit static

Message ID 20210625103436.900a9e962c32.Id45a0d2d0167dd9b6a067b42d791523896574064@changeid
State Accepted
Headers show
Series [1/4] um: make PCI emulation driver init/exit static | expand

Commit Message

Johannes Berg June 25, 2021, 8:34 a.m. UTC
From: Johannes Berg <johannes.berg@intel.com>

The functions aren't used elsewhere, so they can be static.

Reported-by: kernel test robot <lkp@intel.com>
Fixes: 68f5d3f3b654 ("um: add PCI over virtio emulation driver")
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
 arch/um/drivers/virt-pci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Anton Ivanov June 25, 2021, 9:16 a.m. UTC | #1
On 25/06/2021 09:34, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
> 
> The functions aren't used elsewhere, so they can be static.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 68f5d3f3b654 ("um: add PCI over virtio emulation driver")
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
>   arch/um/drivers/virt-pci.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/um/drivers/virt-pci.c b/arch/um/drivers/virt-pci.c
> index 0b802834f40a..70c17de16662 100644
> --- a/arch/um/drivers/virt-pci.c
> +++ b/arch/um/drivers/virt-pci.c
> @@ -810,7 +810,7 @@ void *pci_root_bus_fwnode(struct pci_bus *bus)
>   	return um_pci_fwnode;
>   }
>   
> -int um_pci_init(void)
> +static int um_pci_init(void)
>   {
>   	int err, i;
>   
> @@ -884,7 +884,7 @@ int um_pci_init(void)
>   }
>   module_init(um_pci_init);
>   
> -void um_pci_exit(void)
> +static void um_pci_exit(void)
>   {
>   	unregister_virtio_driver(&um_pci_virtio_driver);
>   	irq_domain_remove(um_pci_msi_domain);
> 

Acked-By: Anton Ivanov <anton.ivanov@cambridgegreys.com>
diff mbox series

Patch

diff --git a/arch/um/drivers/virt-pci.c b/arch/um/drivers/virt-pci.c
index 0b802834f40a..70c17de16662 100644
--- a/arch/um/drivers/virt-pci.c
+++ b/arch/um/drivers/virt-pci.c
@@ -810,7 +810,7 @@  void *pci_root_bus_fwnode(struct pci_bus *bus)
 	return um_pci_fwnode;
 }
 
-int um_pci_init(void)
+static int um_pci_init(void)
 {
 	int err, i;
 
@@ -884,7 +884,7 @@  int um_pci_init(void)
 }
 module_init(um_pci_init);
 
-void um_pci_exit(void)
+static void um_pci_exit(void)
 {
 	unregister_virtio_driver(&um_pci_virtio_driver);
 	irq_domain_remove(um_pci_msi_domain);