| Message ID | 20210508031354.2127-1-thunder.leizhen@huawei.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] um: fix error return code in slip_open() | expand |
On 08/05/2021 04:13, Zhen Lei wrote: > Fix to return a negative error code from the error handling case instead > of 0, as done elsewhere in this function. > > Fixes: a3c77c67a443 ("[PATCH] uml: slirp and slip driver cleanups and fixes") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> > --- > arch/um/drivers/slip_user.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/um/drivers/slip_user.c b/arch/um/drivers/slip_user.c > index 482a19c5105c..7334019c9e60 100644 > --- a/arch/um/drivers/slip_user.c > +++ b/arch/um/drivers/slip_user.c > @@ -145,7 +145,8 @@ static int slip_open(void *data) > } > sfd = err; > > - if (set_up_tty(sfd)) > + err = set_up_tty(sfd); > + if (err) > goto out_close2; > > pri->slave = sfd; > Acked-By: anton.ivanov@cambridgegreys.com
diff --git a/arch/um/drivers/slip_user.c b/arch/um/drivers/slip_user.c index 482a19c5105c..7334019c9e60 100644 --- a/arch/um/drivers/slip_user.c +++ b/arch/um/drivers/slip_user.c @@ -145,7 +145,8 @@ static int slip_open(void *data) } sfd = err; - if (set_up_tty(sfd)) + err = set_up_tty(sfd); + if (err) goto out_close2; pri->slave = sfd;
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: a3c77c67a443 ("[PATCH] uml: slirp and slip driver cleanups and fixes") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> --- arch/um/drivers/slip_user.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)