Message ID | 20201026124702.874c23068ecc.I4c3cbf992dc2c038117a01c2cd9a4c406b89ec94@changeid |
---|---|
State | Superseded |
Headers | show |
Series | um: include compiler_attributes.h where used | expand |
On 26/10/2020 11:47, Johannes Berg wrote: > From: Johannes Berg <johannes.berg@intel.com> > > Joe's commit didn't only convert uses of __section(...) to add > the quotes, but _also_ converted 'raw' uses of __attribute__(()) > for setting the section to use __section, but didn't update the > includes where necessary. Add them now. > > Fixes: 33def8498fdd ("treewide: Convert macro and uses of __section(foo) to __section("foo")") > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> > Cause-identified-by: Christopher Obbard <chris.obbard@collabora.com> > Signed-off-by: Johannes Berg <johannes.berg@intel.com> Tested-by: Christopher Obbard <chris.obbard@collabora.com>
On Mon, 2020-10-26 at 12:47 +0100, Johannes Berg wrote: > From: Johannes Berg <johannes.berg@intel.com> > > Joe's commit didn't only convert uses of __section(...) to add > the quotes, but _also_ converted 'raw' uses of __attribute__(()) > for setting the section to use __section, but didn't update the > includes where necessary. Add them now. Apologies and thank you. I believed the robot had done these compilation tests. > Fixes: 33def8498fdd ("treewide: Convert macro and uses of __section(foo) to __section("foo")") > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> > Cause-identified-by: Christopher Obbard <chris.obbard@collabora.com> > Signed-off-by: Johannes Berg <johannes.berg@intel.com>
diff --git a/arch/um/kernel/skas/clone.c b/arch/um/kernel/skas/clone.c index 95c355181dcd..dfd81d4d0f5f 100644 --- a/arch/um/kernel/skas/clone.c +++ b/arch/um/kernel/skas/clone.c @@ -4,6 +4,7 @@ * Copyright (C) 2007 Jeff Dike (jdike@{addtoit,linux.intel}.com) */ +#include <linux/compiler_attributes.h> #include <signal.h> #include <sched.h> #include <asm/unistd.h> diff --git a/arch/x86/um/stub_segv.c b/arch/x86/um/stub_segv.c index fdcd58af707a..95110ad4f313 100644 --- a/arch/x86/um/stub_segv.c +++ b/arch/x86/um/stub_segv.c @@ -3,6 +3,7 @@ * Licensed under the GPL */ +#include <linux/compiler_attributes.h> #include <sysdep/stub.h> #include <sysdep/faultinfo.h> #include <sysdep/mcontext.h>