diff mbox series

[RFC,01/41] um/stacktrace: Remove the pointless ULONG_MAX marker

Message ID 20190410103643.662853876@linutronix.de
State Not Applicable
Headers show
Series [RFC,01/41] um/stacktrace: Remove the pointless ULONG_MAX marker | expand

Commit Message

Thomas Gleixner April 10, 2019, 10:27 a.m. UTC 
Terminating the last trace entry with ULONG_MAX is a completely pointless
exercise and none of the consumers can rely on it because it's
inconsistently implemented across architectures. In fact quite some of the
callers remove the entry and adjust stack_trace.nr_entries afterwards.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Richard Weinberger <richard@nod.at>
Cc: linux-um@lists.infradead.org
---
 arch/um/kernel/stacktrace.c |    2 --
 1 file changed, 2 deletions(-)
diff mbox series

Patch

--- a/arch/um/kernel/stacktrace.c
+++ b/arch/um/kernel/stacktrace.c
@@ -63,8 +63,6 @@  static const struct stacktrace_ops dump_
 static void __save_stack_trace(struct task_struct *tsk, struct stack_trace *trace)
 {
 	dump_trace(tsk, &dump_ops, trace);
-	if (trace->nr_entries < trace->max_entries)
-		trace->entries[trace->nr_entries++] = ULONG_MAX;
 }
 
 void save_stack_trace(struct stack_trace *trace)