diff mbox series

Don't hardcode path as it is architecture dependent

Message ID 20180920062640.23038-1-rrs@debian.org
State Accepted, archived
Headers show
Series Don't hardcode path as it is architecture dependent | expand

Commit Message

Ritesh Raj Sarraf Sept. 20, 2018, 6:26 a.m. UTC
The current code fails to run on amd64 because of hardcoded reference to
i386

Signed-off-by: Ritesh Raj Sarraf <rrs@researchut.com>
---
 arch/um/drivers/port_user.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Richard Weinberger Sept. 20, 2018, 7:05 p.m. UTC | #1
Am Donnerstag, 20. September 2018, 08:26:38 CEST schrieb Ritesh Raj Sarraf:
> The current code fails to run on amd64 because of hardcoded reference to
> i386
> 
> Signed-off-by: Ritesh Raj Sarraf <rrs@researchut.com>

Thanks for spotting this!

> ---
>  arch/um/drivers/port_user.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/um/drivers/port_user.c b/arch/um/drivers/port_user.c
> index 9a8e1b64c22e..5f56d11b886f 100644
> --- a/arch/um/drivers/port_user.c
> +++ b/arch/um/drivers/port_user.c
> @@ -168,7 +168,7 @@ int port_connection(int fd, int *socket, int *pid_out)
>  {
>  	int new, err;
>  	char *argv[] = { "/usr/sbin/in.telnetd", "-L",
> -			 "/usr/lib/uml/port-helper", NULL };
> +			 OS_LIB_PATH "/uml/port-helper", NULL };
>  	struct port_pre_exec_data data;
>  
>  	new = accept(fd, NULL, 0);

Thanks,
//richard
diff mbox series

Patch

diff --git a/arch/um/drivers/port_user.c b/arch/um/drivers/port_user.c
index 9a8e1b64c22e..5f56d11b886f 100644
--- a/arch/um/drivers/port_user.c
+++ b/arch/um/drivers/port_user.c
@@ -168,7 +168,7 @@  int port_connection(int fd, int *socket, int *pid_out)
 {
 	int new, err;
 	char *argv[] = { "/usr/sbin/in.telnetd", "-L",
-			 "/usr/lib/uml/port-helper", NULL };
+			 OS_LIB_PATH "/uml/port-helper", NULL };
 	struct port_pre_exec_data data;
 
 	new = accept(fd, NULL, 0);