| Message ID | 1615366148-5357-1-git-send-email-yang.lee@linux.alibaba.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | uml: remove unneeded variable 'ret' | expand |
On Wed, 2021-03-10 at 16:49 +0800, Yang Li wrote: > Fix the following coccicheck warning: > ./arch/um/drivers/hostaudio_kern.c:125:10-14: Unneeded variable: "mask". > Return "0" on line 131 Word of caution to you: You've already managed to be in various people's block list due to sending patches such as https://lore.kernel.org/linuxppc-dev/1614243417-48556-1-git-send-email-yang.lee@linux.alibaba.com/ You might want to stop for a while, and *really* carefully look at each and every patch you send out. In this case, you messed up the subject. johannes
diff --git a/arch/um/drivers/hostaudio_kern.c b/arch/um/drivers/hostaudio_kern.c index d35d3f3..5b064d3 100644 --- a/arch/um/drivers/hostaudio_kern.c +++ b/arch/um/drivers/hostaudio_kern.c @@ -122,13 +122,11 @@ static ssize_t hostaudio_write(struct file *file, const char __user *buffer, static __poll_t hostaudio_poll(struct file *file, struct poll_table_struct *wait) { - __poll_t mask = 0; - #ifdef DEBUG printk(KERN_DEBUG "hostaudio: poll called (unimplemented)\n"); #endif - return mask; + return 0; } static long hostaudio_ioctl(struct file *file,
Fix the following coccicheck warning: ./arch/um/drivers/hostaudio_kern.c:125:10-14: Unneeded variable: "mask". Return "0" on line 131 Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- arch/um/drivers/hostaudio_kern.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)