From patchwork Wed Jun 23 11:34:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "tiantao \\(H\\)" X-Patchwork-Id: 1496075 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-tegra-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4G91QS2jtbz9sWQ for ; Wed, 23 Jun 2021 21:34:56 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230061AbhFWLhL (ORCPT ); Wed, 23 Jun 2021 07:37:11 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:11088 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230031AbhFWLhL (ORCPT ); Wed, 23 Jun 2021 07:37:11 -0400 Received: from dggeme758-chm.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4G91Lt2MrkzZhXG; Wed, 23 Jun 2021 19:31:50 +0800 (CST) Received: from dggeme759-chm.china.huawei.com (10.3.19.105) by dggeme758-chm.china.huawei.com (10.3.19.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Wed, 23 Jun 2021 19:34:50 +0800 Received: from dggeme759-chm.china.huawei.com ([10.8.81.151]) by dggeme759-chm.china.huawei.com ([10.8.81.151]) with mapi id 15.01.2176.012; Wed, 23 Jun 2021 19:34:50 +0800 From: "tiantao (H)" Subject: =?eucgb2312_cn?b?tPC4tDogW1BBVENIIHYyIDAyLzIyXSBkcm0vaGlibWM6IENhbGwgZHJt?= =?eucgb2312_cn?b?X2lycV91bmluc3RhbGwoKSB1bmNvbmRpdGlvbmFsbHk=?= Thread-Topic: [PATCH v2 02/22] drm/hibmc: Call drm_irq_uninstall() unconditionally Thread-Index: AQHXZ3BTceWJbDn8OEasIrWUx4ImYqsheBbQ Date: Wed, 23 Jun 2021 11:34:50 +0000 Message-ID: References: <20210622141002.11590-1-tzimmermann@suse.de> <20210622141002.11590-3-tzimmermann@suse.de> In-Reply-To: <20210622141002.11590-3-tzimmermann@suse.de> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.40.188.144] MIME-Version: 1.0 X-CFilter-Loop: Reflected To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org -----邮件原件----- 发件人: Thomas Zimmermann [mailto:tzimmermann@suse.de] 发送时间: 2021年6月22日 22:10 收件人: daniel@ffwll.ch; airlied@linux.ie; alexander.deucher@amd.com; christian.koenig@amd.com; Xinhui.Pan@amd.com; james.qian.wang@arm.com; liviu.dudau@arm.com; mihail.atanassov@arm.com; brian.starkey@arm.com; maarten.lankhorst@linux.intel.com; mripard@kernel.org; inki.dae@samsung.com; jy0922.shim@samsung.com; sw0312.kim@samsung.com; kyungmin.park@samsung.com; krzysztof.kozlowski@canonical.com; xinliang.liu@linaro.org; tiantao (H) ; john.stultz@linaro.org; kongxinwei (A) ; Chenfeng (puck) ; laurentiu.palcu@oss.nxp.com; l.stach@pengutronix.de; p.zabel@pengutronix.de; shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com; linux-imx@nxp.com; chunkuang.hu@kernel.org; matthias.bgg@gmail.com; bskeggs@redhat.com; tomba@kernel.org; hjc@rock-chips.com; heiko@sntech.de; benjamin.gaignard@linaro.org; yannick.fertre@foss.st.com; philippe.cornu@foss.st.com; mcoquelin.stm32@gmail.com; alexandre.torgue@foss.st.com; wens@csie.org; jernej.skrabec@gmail.com; thierry.reding@gmail.com; jonathanh@nvidia.com; jyri.sarha@iki.fi; emma@anholt.net; linux-graphics-maintainer@vmware.com; zackr@vmware.com; hyun.kwon@xilinx.com; laurent.pinchart@ideasonboard.com; michal.simek@xilinx.com 抄送: amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux-arm-kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux-mediatek@lists.infradead.org; nouveau@lists.freedesktop.org; linux-rockchip@lists.infradead.org; linux-stm32@st-md-mailman.stormreply.com; linux-sunxi@lists.linux.dev; linux-tegra@vger.kernel.org; Thomas Zimmermann 主题: [PATCH v2 02/22] drm/hibmc: Call drm_irq_uninstall() unconditionally Remove the check around drm_irq_uninstall(). The same test is done by the function internally. The tested state in irq_enabled is considered obsolete and should not be used by KMS drivers. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Acked-by: Tian Tao diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c index f4bc5386574a..f8ef711bbe5d 100644 --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c @@ -253,8 +253,7 @@ static int hibmc_unload(struct drm_device *dev) { drm_atomic_helper_shutdown(dev); - if (dev->irq_enabled) - drm_irq_uninstall(dev); + drm_irq_uninstall(dev); pci_disable_msi(to_pci_dev(dev->dev)); -- 2.32.0