diff mbox

[V2,1/4] i2c: tegra: Add __devinit/exit to probe/remove

Message ID CAM=Q2cs8K4vraWPNqervcmxEqUGiAbng+44+L9OhD3ijPw9tAA@mail.gmail.com
State Accepted, archived
Headers show

Commit Message

Shubhrajyoti Datta Dec. 20, 2011, 6:15 a.m. UTC 
On Tue, Dec 20, 2011 at 7:26 AM, Olof Johansson <olof@lixom.net> wrote:
> On Sat, Dec 17, 2011 at 11:29:29PM -0700, Stephen Warren wrote:
>> This fixes some section mismatch build warnings.
>>
>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
>
> Ben, since the patch is trivial, I've picked it up in tegra
> for-3.3/drivers and will merge that way. Let me know if you disagree.
>
>
Hi Stephen ,
could you check this one also
thanks.

From: Shubhrajyoti D <shubhrajyoti@ti.com>
Date: Tue, 20 Dec 2011 11:40:51 +0530
Subject: [PATCH] I2C : tegra : devexit in remove

Adding I2C __devexxit in remove

Cc: Stephen Warren <swarren@nvidia.com>
Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
---
Untested

 drivers/i2c/busses/i2c-tegra.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Stephen Warren Dec. 20, 2011, 9:47 p.m. UTC | #1 
Shubhrajyoti Datta wrote at Monday, December 19, 2011 11:15 PM:
...
> Hi Stephen ,
> could you check this one also
> thanks.
> 
> From: Shubhrajyoti D <shubhrajyoti@ti.com>
> Date: Tue, 20 Dec 2011 11:40:51 +0530
> Subject: [PATCH] I2C : tegra : devexit in remove
> 
> Adding I2C __devexxit in remove
> 
> Cc: Stephen Warren <swarren@nvidia.com>
> Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>

Acked-by: Stephen Warren <swarren@nvidia.com>

Ben or Olof,

> -       .remove  = tegra_i2c_remove,
> +       .remove  =__devexit_p(tegra_i2c_remove),

When you apply this, can you fix it up to add a space after the = in
the modified line? If you want, I can post an updated version to do that.
Ben Dooks Jan. 6, 2012, 4:26 p.m. UTC | #2 
On Tue, Dec 20, 2011 at 01:47:29PM -0800, Stephen Warren wrote:
> Shubhrajyoti Datta wrote at Monday, December 19, 2011 11:15 PM:
> ...
> > Hi Stephen ,
> > could you check this one also
> > thanks.
> > 
> > From: Shubhrajyoti D <shubhrajyoti@ti.com>
> > Date: Tue, 20 Dec 2011 11:40:51 +0530
> > Subject: [PATCH] I2C : tegra : devexit in remove
> > 
> > Adding I2C __devexxit in remove
> > 
> > Cc: Stephen Warren <swarren@nvidia.com>
> > Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
> 
> Acked-by: Stephen Warren <swarren@nvidia.com>
> 
> Ben or Olof,
> 
> > -       .remove  = tegra_i2c_remove,
> > +       .remove  =__devexit_p(tegra_i2c_remove),
> 
> When you apply this, can you fix it up to add a space after the = in
> the modified line? If you want, I can post an updated version to do that.

Let me know if you want anything applying or a pull-request processed.

I think once fixed the patches would be fine and I ack them:

Acked-by: Ben Dooks <ben-linux@fluff.org>
 
> -- 
> nvpublic
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
Stephen Warren Jan. 6, 2012, 4:47 p.m. UTC | #3 
Ben Dooks wrote at Friday, January 06, 2012 9:26 AM:
> On Tue, Dec 20, 2011 at 01:47:29PM -0800, Stephen Warren wrote:
> > Shubhrajyoti Datta wrote at Monday, December 19, 2011 11:15 PM:
> > ...
> > > Hi Stephen ,
> > > could you check this one also
> > > thanks.
> > >
> > > From: Shubhrajyoti D <shubhrajyoti@ti.com>
> > > Date: Tue, 20 Dec 2011 11:40:51 +0530
> > > Subject: [PATCH] I2C : tegra : devexit in remove
> > >
> > > Adding I2C __devexxit in remove
> > >
> > > Cc: Stephen Warren <swarren@nvidia.com>
> > > Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
> >
> > Acked-by: Stephen Warren <swarren@nvidia.com>
> >
> > Ben or Olof,
> >
> > > -       .remove  = tegra_i2c_remove,
> > > +       .remove  =__devexit_p(tegra_i2c_remove),
> >
> > When you apply this, can you fix it up to add a space after the = in
> > the modified line? If you want, I can post an updated version to do that.
> 
> Let me know if you want anything applying or a pull-request processed.
> 
> I think once fixed the patches would be fine and I ack them:
> 
> Acked-by: Ben Dooks <ben-linux@fluff.org>

Olof, since you took the original through the Tegra tree, I think it
makes sense for us to take this fix through there too, and for 3.3?
The patch above is http://patchwork.ozlabs.org/patch/132349/
Olof Johansson Jan. 6, 2012, 5:45 p.m. UTC | #4 
On Fri, Jan 6, 2012 at 8:47 AM, Stephen Warren <swarren@nvidia.com> wrote:
> Ben Dooks wrote at Friday, January 06, 2012 9:26 AM:
>> On Tue, Dec 20, 2011 at 01:47:29PM -0800, Stephen Warren wrote:
>> > Shubhrajyoti Datta wrote at Monday, December 19, 2011 11:15 PM:
>> > ...
>> > > Hi Stephen ,
>> > > could you check this one also
>> > > thanks.
>> > >
>> > > From: Shubhrajyoti D <shubhrajyoti@ti.com>
>> > > Date: Tue, 20 Dec 2011 11:40:51 +0530
>> > > Subject: [PATCH] I2C : tegra : devexit in remove
>> > >
>> > > Adding I2C __devexxit in remove
>> > >
>> > > Cc: Stephen Warren <swarren@nvidia.com>
>> > > Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
>> >
>> > Acked-by: Stephen Warren <swarren@nvidia.com>
>> >
>> > Ben or Olof,
>> >
>> > > -       .remove  = tegra_i2c_remove,
>> > > +       .remove  =__devexit_p(tegra_i2c_remove),
>> >
>> > When you apply this, can you fix it up to add a space after the = in
>> > the modified line? If you want, I can post an updated version to do that.
>>
>> Let me know if you want anything applying or a pull-request processed.
>>
>> I think once fixed the patches would be fine and I ack them:
>>
>> Acked-by: Ben Dooks <ben-linux@fluff.org>
>
> Olof, since you took the original through the Tegra tree, I think it
> makes sense for us to take this fix through there too, and for 3.3?
> The patch above is http://patchwork.ozlabs.org/patch/132349/

Yep, will do.


-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Stephen Warren Feb. 4, 2012, 12:05 a.m. UTC | #5 
Olof Johansson wrote at Friday, January 06, 2012 10:45 AM:
> On Fri, Jan 6, 2012 at 8:47 AM, Stephen Warren <swarren@nvidia.com> wrote:
> > Ben Dooks wrote at Friday, January 06, 2012 9:26 AM:
> >> On Tue, Dec 20, 2011 at 01:47:29PM -0800, Stephen Warren wrote:
> >> > Shubhrajyoti Datta wrote at Monday, December 19, 2011 11:15 PM:
> >> > ...
> >> > > Hi Stephen ,
> >> > > could you check this one also
> >> > > thanks.
> >> > >
> >> > > From: Shubhrajyoti D <shubhrajyoti@ti.com>
> >> > > Date: Tue, 20 Dec 2011 11:40:51 +0530
> >> > > Subject: [PATCH] I2C : tegra : devexit in remove
> >> > >
> >> > > Adding I2C __devexxit in remove
> >> > >
> >> > > Cc: Stephen Warren <swarren@nvidia.com>
> >> > > Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
> >> >
> >> > Acked-by: Stephen Warren <swarren@nvidia.com>
> >> >
> >> > Ben or Olof,
> >> >
> >> > > -       .remove  = tegra_i2c_remove,
> >> > > +       .remove  =__devexit_p(tegra_i2c_remove),
> >> >
> >> > When you apply this, can you fix it up to add a space after the = in
> >> > the modified line? If you want, I can post an updated version to do that.
> >>
> >> Let me know if you want anything applying or a pull-request processed.
> >>
> >> I think once fixed the patches would be fine and I ack them:
> >>
> >> Acked-by: Ben Dooks <ben-linux@fluff.org>
> >
> > Olof, since you took the original through the Tegra tree, I think it
> > makes sense for us to take this fix through there too, and for 3.3?
> > The patch above is http://patchwork.ozlabs.org/patch/132349/
> 
> Yep, will do.

I haven't seen this show up anywhere yet.
Olof Johansson Feb. 6, 2012, 4:52 p.m. UTC | #6 
On Fri, Jan 06, 2012 at 08:47:11AM -0800, Stephen Warren wrote:
> Ben Dooks wrote at Friday, January 06, 2012 9:26 AM:
> > On Tue, Dec 20, 2011 at 01:47:29PM -0800, Stephen Warren wrote:
> > > Shubhrajyoti Datta wrote at Monday, December 19, 2011 11:15 PM:
> > > ...
> > > > Hi Stephen ,
> > > > could you check this one also
> > > > thanks.
> > > >
> > > > From: Shubhrajyoti D <shubhrajyoti@ti.com>
> > > > Date: Tue, 20 Dec 2011 11:40:51 +0530
> > > > Subject: [PATCH] I2C : tegra : devexit in remove
> > > >
> > > > Adding I2C __devexxit in remove
> > > >
> > > > Cc: Stephen Warren <swarren@nvidia.com>
> > > > Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
> > >
> > > Acked-by: Stephen Warren <swarren@nvidia.com>
> > >
> > > Ben or Olof,
> > >
> > > > -       .remove  = tegra_i2c_remove,
> > > > +       .remove  =__devexit_p(tegra_i2c_remove),
> > >
> > > When you apply this, can you fix it up to add a space after the = in
> > > the modified line? If you want, I can post an updated version to do that.
> > 
> > Let me know if you want anything applying or a pull-request processed.
> > 
> > I think once fixed the patches would be fine and I ack them:
> > 
> > Acked-by: Ben Dooks <ben-linux@fluff.org>
> 
> Olof, since you took the original through the Tegra tree, I think it
> makes sense for us to take this fix through there too, and for 3.3?
> The patch above is http://patchwork.ozlabs.org/patch/132349/

Done, applied, sorry for the delay.

The patch has whitespace damage but I fixed it up manually.


-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index 46b6500..b25f78b 100644
--- a/drivers/i2c/busses/i2c-tegra.c
+++ b/drivers/i2c/busses/i2c-tegra.c
@@ -751,7 +751,7 @@  MODULE_DEVICE_TABLE(of, tegra_i2c_of_match);

 static struct platform_driver tegra_i2c_driver = {
        .probe   = tegra_i2c_probe,
-       .remove  = tegra_i2c_remove,
+       .remove  =__devexit_p(tegra_i2c_remove),
 #ifdef CONFIG_PM
        .suspend = tegra_i2c_suspend,
        .resume  = tegra_i2c_resume,