From patchwork Mon Jun 13 10:27:38 2016
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Jon Hunter <jonathanh@nvidia.com>
X-Patchwork-Id: 634489
Return-Path: <linux-tegra-owner@vger.kernel.org>
X-Original-To: incoming@patchwork.ozlabs.org
Delivered-To: patchwork-incoming@bilbo.ozlabs.org
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by ozlabs.org (Postfix) with ESMTP id 3rSprL4YCCz9s9r
	for <incoming@patchwork.ozlabs.org>;
	Mon, 13 Jun 2016 20:27:46 +1000 (AEST)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965126AbcFMK1p (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);
	Mon, 13 Jun 2016 06:27:45 -0400
Received: from hqemgate15.nvidia.com ([216.228.121.64]:1544 "EHLO
	hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S964910AbcFMK1o (ORCPT
	<rfc822;linux-tegra@vger.kernel.org>);
	Mon, 13 Jun 2016 06:27:44 -0400
Received: from hqnvupgp08.nvidia.com (Not Verified[216.228.121.13]) by
	hqemgate15.nvidia.com
	id <B575e8a920000>; Mon, 13 Jun 2016 03:27:30 -0700
Received: from HQMAIL108.nvidia.com ([172.20.12.94])
	by hqnvupgp08.nvidia.com (PGP Universal service);
	Mon, 13 Jun 2016 03:25:08 -0700
X-PGP-Universal: processed;
	by hqnvupgp08.nvidia.com on Mon, 13 Jun 2016 03:25:08 -0700
Received: from UKMAIL102.nvidia.com (10.26.138.15) by HQMAIL108.nvidia.com
	(172.18.146.13) with Microsoft SMTP Server (TLS) id 15.0.1130.7;
	Mon, 13 Jun 2016 10:27:42 +0000
Received: from [10.21.132.103] (10.21.132.103) by UKMAIL102.nvidia.com
	(10.26.138.15) with Microsoft SMTP Server (TLS) id 15.0.1130.7;
	Mon, 13 Jun 2016 10:27:39 +0000
Subject: Re: [PATCH V6 9/9] irqchip/gic: Add platform driver for non-root
	GICs that require RPM
To: Marc Zyngier <marc.zyngier@arm.com>,
	Thomas Gleixner <tglx@linutronix.de>, Jason Cooper <jason@lakedaemon.net>
References: <1465312354-27778-1-git-send-email-jonathanh@nvidia.com>
	<1465312354-27778-10-git-send-email-jonathanh@nvidia.com>
	<575E789F.3050509@arm.com> <575E83B8.2050602@nvidia.com>
	<575E8741.8060902@arm.com>
CC: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	"Mark Rutland" <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Kevin Hilman <khilman@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Grygorii Strashko <grygorii.strashko@ti.com>,
	Lars-Peter Clausen <lars@metafoo.de>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	<linux-tegra@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
From: Jon Hunter <jonathanh@nvidia.com>
Message-ID: <575E8A9A.1040907@nvidia.com>
Date: Mon, 13 Jun 2016 11:27:38 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
	Thunderbird/38.8.0
MIME-Version: 1.0
In-Reply-To: <575E8741.8060902@arm.com>
X-Originating-IP: [10.21.132.103]
X-ClientProxiedBy: UKMAIL102.nvidia.com (10.26.138.15) To
	UKMAIL102.nvidia.com (10.26.138.15)
Sender: linux-tegra-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-tegra.vger.kernel.org>
X-Mailing-List: linux-tegra@vger.kernel.org

On 13/06/16 11:13, Marc Zyngier wrote:

...

> OK, that's because ARM_GIC_PM is never selected (and there is no way I
> can actually select). Do you have some additional patches that selects
> it for Tegra?

Yes locally, I have the following for testing ...

>>
>> diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
>> index 57423f3b218b..1de07eb5839c 100644
>> --- a/drivers/irqchip/irq-gic.c
>> +++ b/drivers/irqchip/irq-gic.c
>> @@ -1272,7 +1272,7 @@ static bool gic_check_eoimode(struct device_node *node, void __iomem **base)
>>         return true;
>>  }
>>  
>> -static int __init gic_of_setup(struct gic_chip_data *gic, struct device_node *node)
>> +static int gic_of_setup(struct gic_chip_data *gic, struct device_node *node)
>>  {
>>         if (!gic || !node)
>>                 return -EINVAL;
> 
> OK, I've applied this locally (no need to resend).

Great. Thanks. Sorry about this.

Jon

diff --git a/drivers/soc/tegra/Kconfig b/drivers/soc/tegra/Kconfig
index 03089ad2fc65..ffd02a3c093a 100644
--- a/drivers/soc/tegra/Kconfig
+++ b/drivers/soc/tegra/Kconfig
@@ -63,6 +63,7 @@ config ARCH_TEGRA_132_SOC

 config ARCH_TEGRA_210_SOC
        bool "NVIDIA Tegra210 SoC"
+       select ARM_GIC_PM
        select PINCTRL_TEGRA210

>> The correct fix is ...