From patchwork Sat Dec 19 11:56:54 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 559182 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 0636C14031B for ; Sat, 19 Dec 2015 22:57:13 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932443AbbLSL5L (ORCPT ); Sat, 19 Dec 2015 06:57:11 -0500 Received: from mout.web.de ([212.227.17.12]:56638 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932252AbbLSL5K (ORCPT ); Sat, 19 Dec 2015 06:57:10 -0500 Received: from [192.168.1.3] ([78.53.50.164]) by smtp.web.de (mrweb102) with ESMTPSA (Nemesis) id 0LcPSk-1aaH1h1pOI-00jnfJ; Sat, 19 Dec 2015 12:56:59 +0100 To: linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org, =?UTF-8?Q?Terje_Bergstr=c3=b6m?= , Thierry Reding Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Subject: [PATCH] GPU-host1x: Use a signed return type for do_relocs() Message-ID: <56754606.6060201@users.sourceforge.net> Date: Sat, 19 Dec 2015 12:56:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 X-Provags-ID: V03:K0:vSSsmrewTuIfwriNdgXlQthZr71/0t/yXYxL48Qv6KkIY/wr8ZB oTTORKxardd+8VAvKaWprMtXoU/QVjnCdfJmUNQN4wr6nSsq5O43BGIWz1n/20LMj1hRWyn qpXLakA9GgWBhcm+lTIHVsbh3lI1hGDzeatDNEwlqIbk39P/v4o9cVUgNDNyhlzNiXLtvm8 UAHe9HhkTjvlbqjbenclw== X-UI-Out-Filterresults: notjunk:1; V01:K0:sMGivfOasGg=:hrY/xZZ18FIpnmEVu5IWld 3FkteLt0JiBiV0H/CSAnlQJDocq+COprHZnUqfOzpouwrW6khgog1vAJ6/nzPGrZmyRM1jdND 7pQwebLkzIOze0Ge8na7ho7j9dJpO615Q55CjzROfT+PUubfH5AvexR+9VHc6JBfx3tfIFKQk FaLi2AVWNynr8AOoNO0hH2h/UmeD88rSKCSmAPJcWhvRo8QmUrUqUQnOrPYJrzTgfJpSTy3MI 4uPs5Z5XwUJbZnIDUzb9XkpVg59m5ms1rBloWfAbOWw+Gzg8skLYbMu+sFXudOZuSd6umUkfj 0aH+pFyWmP8RniavEziVyM9zW61RLsVGv3ND5FZw1QhQ6gOL5icbeNR1du3evvOJM8sjUPaie +jo9c+t1F582L2Aq7DHbPw/iiWspXcSLS3et3YE8Ocp+9+DIF+RI9yjPnPv57Yi7tIugUE4iA kPGLd5a/dDlmEbTOjf8uZKTYzx2RyysTDHMawCJMmb9PYumdn/0lG1Ljvbb9QCRYersLujHHf raVoZ+QA8bFJ+++zE6bC44vSsNjDKpIVXus+wMBzKfcoNw+c1uwhHX715AyebtibXZUqdE/DZ DSQZUU/HTVZxIgqhOcarbcrvZyCTMIoBmq/EG7feNhl0b9MgIky8JccCHsDtQus91GXTU+ILr /JFz/N8FmDlbYWegEozbe5PMYWHZO/ACSDR4Tv3wSs27ihHMMGEvjKu90Xksh88Ic2K3GuXv4 voRnUWz/79un2LI1U6RXNmvkbXSfPNtbGgVac14OQoyHpA/y5YseNrz6m4wZSI79+RcIjbWas x+sv4lA Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org From: Markus Elfring Date: Sat, 19 Dec 2015 12:48:31 +0100 The return type "unsigned int" was used by the do_relocs() function despite of the aspect that it will eventually return a negative error code. Improve this implementation detail by deletion of the type qualifier then. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/gpu/host1x/job.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/host1x/job.c b/drivers/gpu/host1x/job.c index 63bd63f..1919aab 100644 --- a/drivers/gpu/host1x/job.c +++ b/drivers/gpu/host1x/job.c @@ -225,7 +225,7 @@ unpin: return 0; } -static unsigned int do_relocs(struct host1x_job *job, struct host1x_bo *cmdbuf) +static int do_relocs(struct host1x_job *job, struct host1x_bo *cmdbuf) { int i = 0; u32 last_page = ~0;