| Message ID | 20260515-tegra194-qspi-iommu-v1-1-57dfb63cd3d6@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | arm64: tegra: Add iommu and dma properties for Tegra194 QSPI | expand |
On Fri, May 15, 2026 at 03:35:27PM -0500, Aaron Kling wrote: > This is supported via an external dma controller > > Signed-off-by: Aaron Kling <webgeek1234@gmail.com> > --- > Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> Best regards, Krzysztof
On Fri, May 15, 2026 at 03:35:27PM -0500, Aaron Kling via B4 Relay wrote: > From: Aaron Kling <webgeek1234@gmail.com> > > This is supported via an external dma controller You say this yourself: it's supported via an external controller, therefore the QSPI controller on Tegra194 (and earlier) does not need the iommus property because it does not itself perform the DMA. The GPC DMA has the iommus property, QSPI doesn't need it. This is different on Tegra234 and later where the QSPI has a built-in DMA controller and does not rely on GPC DMA any longer. Thierry
diff --git a/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml b/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml index 909c204b8adf81..62233eb3101aeb 100644 --- a/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml +++ b/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml @@ -78,7 +78,9 @@ allOf: compatible: not: contains: - const: nvidia,tegra234-qspi + enum: + - nvidia,tegra194-qspi + - nvidia,tegra234-qspi then: properties: iommus: false