| Message ID | 20251008073046.23231-12-clamor95@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | tegra-video: add CSI support for Tegra20 and Tegra30 | expand |
On Wed, Oct 08, 2025 at 10:30:33AM +0300, Svyatoslav Ryhel wrote: > Document MIPI calibration device found in Tegra132. Could you explain why a fallback is not suitable? The patchset is really too big for me to trivially check that the change is correct. With an explanation, Acked-by: Conor Dooley <conor.dooley@microchip.com> > > Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com> > --- > .../devicetree/bindings/display/tegra/nvidia,tegra114-mipi.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra114-mipi.yaml b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra114-mipi.yaml > index 193ddb105283..9a500f52f01d 100644 > --- a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra114-mipi.yaml > +++ b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra114-mipi.yaml > @@ -18,6 +18,7 @@ properties: > enum: > - nvidia,tegra114-mipi > - nvidia,tegra124-mipi > + - nvidia,tegra132-mipi > - nvidia,tegra210-mipi > - nvidia,tegra186-mipi > > -- > 2.48.1 >
чт, 9 жовт. 2025 р. о 00:14 Conor Dooley <conor@kernel.org> пише: > > On Wed, Oct 08, 2025 at 10:30:33AM +0300, Svyatoslav Ryhel wrote: > > Document MIPI calibration device found in Tegra132. > > Could you explain why a fallback is not suitable? The patchset is really > too big for me to trivially check that the change is correct. First of all, this compatible already exists in Linux kernel, I have just documented it to satisfy warnings. Secondly, each Tegra SoC generation has unique set of registers which should be configured. They all differ, hence fallback is not suitable here. > With an explanation, > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > > > > Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com> > > --- > > .../devicetree/bindings/display/tegra/nvidia,tegra114-mipi.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra114-mipi.yaml b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra114-mipi.yaml > > index 193ddb105283..9a500f52f01d 100644 > > --- a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra114-mipi.yaml > > +++ b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra114-mipi.yaml > > @@ -18,6 +18,7 @@ properties: > > enum: > > - nvidia,tegra114-mipi > > - nvidia,tegra124-mipi > > + - nvidia,tegra132-mipi > > - nvidia,tegra210-mipi > > - nvidia,tegra186-mipi > > > > -- > > 2.48.1 > >
On Thu, Oct 09, 2025 at 08:12:11AM +0300, Svyatoslav Ryhel wrote: > чт, 9 жовт. 2025 р. о 00:14 Conor Dooley <conor@kernel.org> пише: > > > > On Wed, Oct 08, 2025 at 10:30:33AM +0300, Svyatoslav Ryhel wrote: > > > Document MIPI calibration device found in Tegra132. > > > > Could you explain why a fallback is not suitable? The patchset is really > > too big for me to trivially check that the change is correct. > > First of all, this compatible already exists in Linux kernel, I have > just documented it to satisfy warnings. Secondly, each Tegra SoC > generation has unique set of registers which should be configured. > They all differ, hence fallback is not suitable here. Okay, then put that in your commit message. > > > With an explanation, > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > > > > > > > Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com> > > > --- > > > .../devicetree/bindings/display/tegra/nvidia,tegra114-mipi.yaml | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra114-mipi.yaml b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra114-mipi.yaml > > > index 193ddb105283..9a500f52f01d 100644 > > > --- a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra114-mipi.yaml > > > +++ b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra114-mipi.yaml > > > @@ -18,6 +18,7 @@ properties: > > > enum: > > > - nvidia,tegra114-mipi > > > - nvidia,tegra124-mipi > > > + - nvidia,tegra132-mipi > > > - nvidia,tegra210-mipi > > > - nvidia,tegra186-mipi > > > > > > -- > > > 2.48.1 > > >
diff --git a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra114-mipi.yaml b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra114-mipi.yaml index 193ddb105283..9a500f52f01d 100644 --- a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra114-mipi.yaml +++ b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra114-mipi.yaml @@ -18,6 +18,7 @@ properties: enum: - nvidia,tegra114-mipi - nvidia,tegra124-mipi + - nvidia,tegra132-mipi - nvidia,tegra210-mipi - nvidia,tegra186-mipi
Document MIPI calibration device found in Tegra132. Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com> --- .../devicetree/bindings/display/tegra/nvidia,tegra114-mipi.yaml | 1 + 1 file changed, 1 insertion(+)