| Message ID | 20250729145911.2984981-1-thierry.reding@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | firmware: tegra: Do not warn on missing memory-region property | expand |
On Tue, Jul 29, 2025 at 9:59 AM Thierry Reding <thierry.reding@gmail.com> wrote: > > From: Thierry Reding <treding@nvidia.com> > > The IPC shared memory can reside in system memory or SRAM. In the latter > case the memory-region property is expected not to be present, so do not > warn about it. Then shouldn't the only warning be you couldn't find either one? The exact reason shouldn't be that important. > > Reported-by: Jonathan Hunter <jonathanh@nvidia.com> > Fixes: dbe4efea38d0 ("firmware: tegra: bpmp: Use of_reserved_mem_region_to_resource() for "memory-region"") > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- > drivers/firmware/tegra/bpmp-tegra186.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/firmware/tegra/bpmp-tegra186.c b/drivers/firmware/tegra/bpmp-tegra186.c > index 7cfc5fdfa49d..64863db7a715 100644 > --- a/drivers/firmware/tegra/bpmp-tegra186.c > +++ b/drivers/firmware/tegra/bpmp-tegra186.c > @@ -198,7 +198,10 @@ static int tegra186_bpmp_dram_init(struct tegra_bpmp *bpmp) > > err = of_reserved_mem_region_to_resource(bpmp->dev->of_node, 0, &res); > if (err < 0) { > - dev_warn(bpmp->dev, "failed to parse memory region: %d\n", err); > + if (err != -ENODEV) > + dev_warn(bpmp->dev, > + "failed to parse memory region: %d\n", err); > + > return err; > } > > -- > 2.50.0 >
On 29/07/2025 16:50, Rob Herring wrote: > On Tue, Jul 29, 2025 at 9:59 AM Thierry Reding <thierry.reding@gmail.com> wrote: >> >> From: Thierry Reding <treding@nvidia.com> >> >> The IPC shared memory can reside in system memory or SRAM. In the latter >> case the memory-region property is expected not to be present, so do not >> warn about it. > > Then shouldn't the only warning be you couldn't find either one? The > exact reason shouldn't be that important. This code is checking if it exists in system memory. If this fails, then we try SRAM, but that is checked in a different function. So at this point we only know it is not present in system memory. So here we only want to warn if the 'memory-region' property exists but parsing it fails. >> Reported-by: Jonathan Hunter <jonathanh@nvidia.com> >> Fixes: dbe4efea38d0 ("firmware: tegra: bpmp: Use of_reserved_mem_region_to_resource() for "memory-region"") >> Signed-off-by: Thierry Reding <treding@nvidia.com> >> --- >> drivers/firmware/tegra/bpmp-tegra186.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/firmware/tegra/bpmp-tegra186.c b/drivers/firmware/tegra/bpmp-tegra186.c >> index 7cfc5fdfa49d..64863db7a715 100644 >> --- a/drivers/firmware/tegra/bpmp-tegra186.c >> +++ b/drivers/firmware/tegra/bpmp-tegra186.c >> @@ -198,7 +198,10 @@ static int tegra186_bpmp_dram_init(struct tegra_bpmp *bpmp) >> >> err = of_reserved_mem_region_to_resource(bpmp->dev->of_node, 0, &res); >> if (err < 0) { >> - dev_warn(bpmp->dev, "failed to parse memory region: %d\n", err); >> + if (err != -ENODEV) >> + dev_warn(bpmp->dev, >> + "failed to parse memory region: %d\n", err); >> + >> return err; >> } Reviewed-by: Jon Hunter <jonthanh@nvidia.com> Tested-by: Jon Hunter <jonthanh@nvidia.com> Thanks Jon
diff --git a/drivers/firmware/tegra/bpmp-tegra186.c b/drivers/firmware/tegra/bpmp-tegra186.c index 7cfc5fdfa49d..64863db7a715 100644 --- a/drivers/firmware/tegra/bpmp-tegra186.c +++ b/drivers/firmware/tegra/bpmp-tegra186.c @@ -198,7 +198,10 @@ static int tegra186_bpmp_dram_init(struct tegra_bpmp *bpmp) err = of_reserved_mem_region_to_resource(bpmp->dev->of_node, 0, &res); if (err < 0) { - dev_warn(bpmp->dev, "failed to parse memory region: %d\n", err); + if (err != -ENODEV) + dev_warn(bpmp->dev, + "failed to parse memory region: %d\n", err); + return err; }