| Message ID | 20250512051747.1026770-2-sheetal@nvidia.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add Tegra264 support in AHUB drivers | expand |
On Mon, 12 May 2025 05:17:37 +0000, Sheetal . wrote: > From: Sheetal <sheetal@nvidia.com> > > Add optional interconnect and iommu properties to admaif yaml. These > properties are supported from Tegra186 SoC onwards. > > This fixes below dtbs_check error for Tegra194 and Tegra234: > 'interconnect-names', 'interconnects', 'iommus' do not match any of the regexes: 'pinctrl-[0-9]+' > > Signed-off-by: Sheetal <sheetal@nvidia.com> > --- > .../bindings/sound/nvidia,tegra210-admaif.yaml | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > Acked-by: Rob Herring (Arm) <robh@kernel.org>
On 12/05/2025 07:17, Sheetal . wrote: > From: Sheetal <sheetal@nvidia.com> > > Add optional interconnect and iommu properties to admaif yaml. These > properties are supported from Tegra186 SoC onwards. > > This fixes below dtbs_check error for Tegra194 and Tegra234: > 'interconnect-names', 'interconnects', 'iommus' do not match any of the regexes: 'pinctrl-[0-9]+' You never responded - I reported it is not possible to reproduce it. Instead of sending the same, please address the feedback. How this can be reproduced? Best regards, Krzysztof
On 22-05-2025 19:55, Krzysztof Kozlowski wrote: > External email: Use caution opening links or attachments > > > On 12/05/2025 07:17, Sheetal . wrote: >> From: Sheetal <sheetal@nvidia.com> >> >> Add optional interconnect and iommu properties to admaif yaml. These >> properties are supported from Tegra186 SoC onwards. >> >> This fixes below dtbs_check error for Tegra194 and Tegra234: >> 'interconnect-names', 'interconnects', 'iommus' do not match any of the regexes: 'pinctrl-[0-9]+' > > > You never responded - I reported it is not possible to reproduce it. > Instead of sending the same, please address the feedback. > > How this can be reproduced? Apologies for misinterpreting the comment. I have updated the patch with properties based on compatibles and add info from which SoC onwards these properties can be used. Below command throws the errors for all the Tegra194 and Tegra234 dtbs, "make dtbs_check DT_SCHEMA_FILES=nvidia,tegra210-admaif.yaml" > > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-admaif.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-admaif.yaml index 15ab40aeab1e..bcecac5d9018 100644 --- a/Documentation/devicetree/bindings/sound/nvidia,tegra210-admaif.yaml +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-admaif.yaml @@ -39,6 +39,19 @@ properties: dma-names: true + interconnects: + items: + - description: APE read memory client + - description: APE write memory client + + interconnect-names: + items: + - const: dma-mem # read + - const: write + + iommus: + maxItems: 1 + ports: $ref: /schemas/graph.yaml#/properties/ports description: | @@ -74,6 +87,9 @@ then: Should be "tx1", "tx2" ... "tx10" for DMA Tx channel minItems: 1 maxItems: 20 + interconnects: false + interconnect-names: false + iommus: false else: properties: