Message ID | 20250508123520.973675-2-sheetal@nvidia.com |
---|---|
State | New |
Headers | show |
Series | Add Tegra264 support in ADMA driver | expand |
On 08/05/2025 14:35, Sheetal . wrote: > From: Sheetal <sheetal@nvidia.com> > > Add Tegra264 ADMA support to the device tree bindings documentation. > The Tegra264 ADMA hardware supports 64 DMA channels and requires > specific register configurations. > > The binding maintains compatibility with existing Tegra platforms > while adding support for Tegra264-specific features. This is confusing sentence, because you did not make anything compatible there. Drop it. > > Signed-off-by: Sheetal <sheetal@nvidia.com> > --- > Documentation/devicetree/bindings/dma/nvidia,tegra210-adma.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/dma/nvidia,tegra210-adma.yaml b/Documentation/devicetree/bindings/dma/nvidia,tegra210-adma.yaml > index d3f8c269916c..d204be46b90e 100644 > --- a/Documentation/devicetree/bindings/dma/nvidia,tegra210-adma.yaml > +++ b/Documentation/devicetree/bindings/dma/nvidia,tegra210-adma.yaml > @@ -19,6 +19,7 @@ properties: > - enum: > - nvidia,tegra210-adma > - nvidia,tegra186-adma > + - nvidia,tegra264-adma This is incomplete, missing constraints. Read *ENTIRE* binding, not top 25 lines only. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/dma/nvidia,tegra210-adma.yaml b/Documentation/devicetree/bindings/dma/nvidia,tegra210-adma.yaml index d3f8c269916c..d204be46b90e 100644 --- a/Documentation/devicetree/bindings/dma/nvidia,tegra210-adma.yaml +++ b/Documentation/devicetree/bindings/dma/nvidia,tegra210-adma.yaml @@ -19,6 +19,7 @@ properties: - enum: - nvidia,tegra210-adma - nvidia,tegra186-adma + - nvidia,tegra264-adma - items: - enum: - nvidia,tegra234-adma