| Message ID | 20250506095936.10687-1-akhilrajeev@nvidia.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/4] dt-bindings: i2c: Specify reset as optional | expand |
On Di, 2025-05-06 at 15:29 +0530, Akhil R wrote: > Specify reset as optional in the description for controllers that has an > internal software reset available > > Signed-off-by: Akhil R <akhilrajeev@nvidia.com> > --- > Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml > index b57ae6963e62..19aefc022c8b 100644 > --- a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml > +++ b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml > @@ -97,7 +97,9 @@ properties: > > resets: > items: > - - description: module reset > + - description: | > + Module reset. This property is optional for controllers in Tegra194 and later > + chips where an internal software reset is available as an alternative. If the module reset was not optional before, shouldn't the resets property have been marked as required? Then, instead of the comment, you could conditionally remove the required status for nvidia,tegra194- i2c. regards Philipp
On Tue, May 06, 2025 at 03:29:33PM +0530, Akhil R wrote: > Specify reset as optional in the description for controllers that has an > internal software reset available Optionality of properties is not determined by text. The property is not marked required in the binding, and therefore is optionally on all platforms. If some platforms require it, you should submit a patch making it mandatory there (via the required keyword). Cheers, Conor. > > Signed-off-by: Akhil R <akhilrajeev@nvidia.com> > --- > Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml > index b57ae6963e62..19aefc022c8b 100644 > --- a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml > +++ b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml > @@ -97,7 +97,9 @@ properties: > > resets: > items: > - - description: module reset > + - description: | > + Module reset. This property is optional for controllers in Tegra194 and later > + chips where an internal software reset is available as an alternative. > > reset-names: > items: > -- > 2.43.2 > >
From: Thierry Reding <treding@nvidia.com> On Tue, 06 May 2025 15:29:33 +0530, Akhil R wrote: > Specify reset as optional in the description for controllers that has an > internal software reset available > > Applied, thanks! [4/4] arm64: tegra: Add I2C aliases for Tegra234 commit: 34c6ba89e1487181b4278e5c1b329327439ec715 Best regards,
Hi Akhil, I am assuming you are going to send a v2 for patches 1 to 3 with the proposed changes? Andi On Tue, May 06, 2025 at 03:29:33PM +0530, Akhil R wrote: > Specify reset as optional in the description for controllers that has an > internal software reset available > > Signed-off-by: Akhil R <akhilrajeev@nvidia.com> > --- > Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml > index b57ae6963e62..19aefc022c8b 100644 > --- a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml > +++ b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml > @@ -97,7 +97,9 @@ properties: > > resets: > items: > - - description: module reset > + - description: | > + Module reset. This property is optional for controllers in Tegra194 and later > + chips where an internal software reset is available as an alternative. > > reset-names: > items: > -- > 2.43.2 >
> Hi Akhil, > > I am assuming you are going to send a v2 for patches 1 to 3 with the proposed > changes? Hi Andi, Yes, I will send out a new version. Thanks Philipp and Conor for the reviews. Will send an updated patch making 'reset' required for the appropriate compatible. Regards, Akhil
diff --git a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml index b57ae6963e62..19aefc022c8b 100644 --- a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml +++ b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml @@ -97,7 +97,9 @@ properties: resets: items: - - description: module reset + - description: | + Module reset. This property is optional for controllers in Tegra194 and later + chips where an internal software reset is available as an alternative. reset-names: items:
Specify reset as optional in the description for controllers that has an internal software reset available Signed-off-by: Akhil R <akhilrajeev@nvidia.com> --- Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)