| Message ID | 20230831123846.3137304-1-ruanjinjie@huawei.com |
|---|---|
| State | Rejected |
| Headers | show |
| Series | iommu/tegra-smmu: Fix the NULL vs IS_ERR() bug for debugfs_create_dir() | expand |
On 2023/8/31 20:38, Jinjie Ruan wrote: > The debugfs_create_dir() function returns error pointers. > It never returns NULL. So use IS_ERR() to check it. > > Fixes: d1313e7896e9 ("iommu/tegra-smmu: Add debugfs support") > Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com> > --- > drivers/iommu/tegra-smmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c > index e445f80d0226..cd1d80c4c673 100644 > --- a/drivers/iommu/tegra-smmu.c > +++ b/drivers/iommu/tegra-smmu.c > @@ -1056,7 +1056,7 @@ DEFINE_SHOW_ATTRIBUTE(tegra_smmu_clients); > static void tegra_smmu_debugfs_init(struct tegra_smmu *smmu) > { > smmu->debugfs = debugfs_create_dir("smmu", NULL); > - if (!smmu->debugfs) > + if (IS_ERR(smmu->debugfs)) > return; There is no need to check the return value of debugfs_create_dir(). This change cannot fix anything as far as I can see. Just remove the check. > > debugfs_create_file("swgroups", S_IRUGO, smmu->debugfs, smmu, Best regards, baolu
On Fri, Sep 01, 2023 at 11:05:48AM +0800, Baolu Lu wrote: > On 2023/8/31 20:38, Jinjie Ruan wrote: > > The debugfs_create_dir() function returns error pointers. > > It never returns NULL. So use IS_ERR() to check it. > > > > Fixes: d1313e7896e9 ("iommu/tegra-smmu: Add debugfs support") > > Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com> > > --- > > drivers/iommu/tegra-smmu.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c > > index e445f80d0226..cd1d80c4c673 100644 > > --- a/drivers/iommu/tegra-smmu.c > > +++ b/drivers/iommu/tegra-smmu.c > > @@ -1056,7 +1056,7 @@ DEFINE_SHOW_ATTRIBUTE(tegra_smmu_clients); > > static void tegra_smmu_debugfs_init(struct tegra_smmu *smmu) > > { > > smmu->debugfs = debugfs_create_dir("smmu", NULL); > > - if (!smmu->debugfs) > > + if (IS_ERR(smmu->debugfs)) > > return; > > There is no need to check the return value of debugfs_create_dir(). This > change cannot fix anything as far as I can see. Just remove the > check. Right Jason
diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c index e445f80d0226..cd1d80c4c673 100644 --- a/drivers/iommu/tegra-smmu.c +++ b/drivers/iommu/tegra-smmu.c @@ -1056,7 +1056,7 @@ DEFINE_SHOW_ATTRIBUTE(tegra_smmu_clients); static void tegra_smmu_debugfs_init(struct tegra_smmu *smmu) { smmu->debugfs = debugfs_create_dir("smmu", NULL); - if (!smmu->debugfs) + if (IS_ERR(smmu->debugfs)) return; debugfs_create_file("swgroups", S_IRUGO, smmu->debugfs, smmu,
The debugfs_create_dir() function returns error pointers. It never returns NULL. So use IS_ERR() to check it. Fixes: d1313e7896e9 ("iommu/tegra-smmu: Add debugfs support") Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com> --- drivers/iommu/tegra-smmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)