| Message ID | 20230524092150.11776-2-tzimmermann@suse.de |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | drm/fbdev: Remove DRM's helpers for fbdev I/O | expand |
Reviewed-by: Sui Jingfeng <suijingfeng@loongson.cn> On 2023/5/24 17:21, Thomas Zimmermann wrote: > Many fbdev drivers use the same set of fb_ops helpers. Add Kconfig > options to select them at once. This will help with making DRM's > fbdev emulation code more modular, but can also be used to simplify > fbdev's driver configs. > > v3: > * fix select statement (Jingfeng) > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > --- > drivers/video/fbdev/Kconfig | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig > index e8889035c882..6df9bd09454a 100644 > --- a/drivers/video/fbdev/Kconfig > +++ b/drivers/video/fbdev/Kconfig > @@ -158,6 +158,27 @@ config FB_DEFERRED_IO > bool > depends on FB > > +config FB_IO_HELPERS > + bool > + depends on FB > + select FB_CFB_COPYAREA > + select FB_CFB_FILLRECT > + select FB_CFB_IMAGEBLIT > + > +config FB_SYS_HELPERS > + bool > + depends on FB > + select FB_SYS_COPYAREA > + select FB_SYS_FILLRECT > + select FB_SYS_FOPS > + select FB_SYS_IMAGEBLIT > + > +config FB_SYS_HELPERS_DEFERRED > + bool > + depends on FB > + select FB_DEFERRED_IO > + select FB_SYS_HELPERS > + > config FB_HECUBA > tristate > depends on FB
Hi Thomas, On Wed, May 24, 2023 at 11:21:38AM +0200, Thomas Zimmermann wrote: > Many fbdev drivers use the same set of fb_ops helpers. Add Kconfig > options to select them at once. This will help with making DRM's > fbdev emulation code more modular, but can also be used to simplify > fbdev's driver configs. > > v3: > * fix select statement (Jingfeng) > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> I like these, thanks. Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig index e8889035c882..6df9bd09454a 100644 --- a/drivers/video/fbdev/Kconfig +++ b/drivers/video/fbdev/Kconfig @@ -158,6 +158,27 @@ config FB_DEFERRED_IO bool depends on FB +config FB_IO_HELPERS + bool + depends on FB + select FB_CFB_COPYAREA + select FB_CFB_FILLRECT + select FB_CFB_IMAGEBLIT + +config FB_SYS_HELPERS + bool + depends on FB + select FB_SYS_COPYAREA + select FB_SYS_FILLRECT + select FB_SYS_FOPS + select FB_SYS_IMAGEBLIT + +config FB_SYS_HELPERS_DEFERRED + bool + depends on FB + select FB_DEFERRED_IO + select FB_SYS_HELPERS + config FB_HECUBA tristate depends on FB
Many fbdev drivers use the same set of fb_ops helpers. Add Kconfig options to select them at once. This will help with making DRM's fbdev emulation code more modular, but can also be used to simplify fbdev's driver configs. v3: * fix select statement (Jingfeng) Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> --- drivers/video/fbdev/Kconfig | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)