| Message ID | 20230202161750.21210-4-kyarlagadda@nvidia.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Tegra TPM driver with hw flow control | expand |
On 02/02/2023 17:17, Krishna Yarlagadda wrote: > Add "nvidia,wait-polling" flag to enable TCG TIS hardware flow control. > > Signed-off-by: Krishna Yarlagadda <kyarlagadda@nvidia.com> > --- > .../bindings/spi/nvidia,tegra210-quad-peripheral-props.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad-peripheral-props.yaml b/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad-peripheral-props.yaml > index 2c3cada75339..25150d55603e 100644 > --- a/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad-peripheral-props.yaml > +++ b/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad-peripheral-props.yaml > @@ -28,5 +28,11 @@ properties: > $ref: /schemas/types.yaml#/definitions/uint32 > minimum: 0 > maximum: 255 > +properties: > + nvidia,wait-polling: > + description: > + Enable TPM wait polling feature for QSPI as specified in TCG PC Client > + Specific TPM Interface Specification (TIS). > + $ref: /schemas/types.yaml#/definitions/flag Does not look like you tested the bindings. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad-peripheral-props.yaml b/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad-peripheral-props.yaml index 2c3cada75339..25150d55603e 100644 --- a/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad-peripheral-props.yaml +++ b/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad-peripheral-props.yaml @@ -28,5 +28,11 @@ properties: $ref: /schemas/types.yaml#/definitions/uint32 minimum: 0 maximum: 255 +properties: + nvidia,wait-polling: + description: + Enable TPM wait polling feature for QSPI as specified in TCG PC Client + Specific TPM Interface Specification (TIS). + $ref: /schemas/types.yaml#/definitions/flag additionalProperties: true
Add "nvidia,wait-polling" flag to enable TCG TIS hardware flow control. Signed-off-by: Krishna Yarlagadda <kyarlagadda@nvidia.com> --- .../bindings/spi/nvidia,tegra210-quad-peripheral-props.yaml | 6 ++++++ 1 file changed, 6 insertions(+)