| Message ID | 20221212222549.3779846-4-u.kleine-koenig@pengutronix.de |
|---|---|
| State | Accepted |
| Headers | show |
| Series | soc: Drop empty platform remove function | expand |
Hello, On Mon, Dec 12, 2022 at 11:25:49PM +0100, Uwe Kleine-König wrote: > A remove callback just returning 0 is equivalent to no remove callback > at all. So drop the useless function. the other two patches in this series were applied individually to their matching trees. For this one I didn't get feedback yet. Best regards Uwe
Hello, [adding Sumit Gupta to Cc who authored all commits to this driver so far, context available at https://lore.kernel.org/r/20221212222549.3779846-4-u.kleine-koenig@pengutronix.de] On Thu, Jan 12, 2023 at 10:55:11PM +0100, Uwe Kleine-König wrote: > On Mon, Dec 12, 2022 at 11:25:49PM +0100, Uwe Kleine-König wrote: > > A remove callback just returning 0 is equivalent to no remove callback > > at all. So drop the useless function. > > the other two patches in this series were applied individually to their > matching trees. For this one I didn't get feedback yet. Did this patch fell through the cracks? Is it just -ENOMAINTAINERTIME? Best regards Uwe
On 13/12/22 03:55, Uwe Kleine-König wrote: > External email: Use caution opening links or attachments > > > A remove callback just returning 0 is equivalent to no remove callback > at all. So drop the useless function. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Sumit Gupta <sumitg@nvidia.com> > --- > drivers/soc/tegra/cbb/tegra234-cbb.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/soc/tegra/cbb/tegra234-cbb.c b/drivers/soc/tegra/cbb/tegra234-cbb.c > index 3528f9e15d5c..3b26dcf9a70c 100644 > --- a/drivers/soc/tegra/cbb/tegra234-cbb.c > +++ b/drivers/soc/tegra/cbb/tegra234-cbb.c > @@ -1066,11 +1066,6 @@ static int tegra234_cbb_probe(struct platform_device *pdev) > return tegra_cbb_register(&cbb->base); > } > > -static int tegra234_cbb_remove(struct platform_device *pdev) > -{ > - return 0; > -} > - > static int __maybe_unused tegra234_cbb_resume_noirq(struct device *dev) > { > struct tegra234_cbb *cbb = dev_get_drvdata(dev); > @@ -1088,7 +1083,6 @@ static const struct dev_pm_ops tegra234_cbb_pm = { > > static struct platform_driver tegra234_cbb_driver = { > .probe = tegra234_cbb_probe, > - .remove = tegra234_cbb_remove, > .driver = { > .name = "tegra234-cbb", > .of_match_table = tegra234_cbb_dt_ids, > -- > 2.38.1 >
From: Thierry Reding <treding@nvidia.com> On Mon, 12 Dec 2022 23:25:49 +0100, Uwe Kleine-König wrote: > A remove callback just returning 0 is equivalent to no remove callback > at all. So drop the useless function. > > Applied, thanks! [3/3] soc: tegra: cbb: Drop empty platform remove function commit: c299a2e6bf944b4218acc194a1cdf500b34e80aa Best regards,
diff --git a/drivers/soc/tegra/cbb/tegra234-cbb.c b/drivers/soc/tegra/cbb/tegra234-cbb.c index 3528f9e15d5c..3b26dcf9a70c 100644 --- a/drivers/soc/tegra/cbb/tegra234-cbb.c +++ b/drivers/soc/tegra/cbb/tegra234-cbb.c @@ -1066,11 +1066,6 @@ static int tegra234_cbb_probe(struct platform_device *pdev) return tegra_cbb_register(&cbb->base); } -static int tegra234_cbb_remove(struct platform_device *pdev) -{ - return 0; -} - static int __maybe_unused tegra234_cbb_resume_noirq(struct device *dev) { struct tegra234_cbb *cbb = dev_get_drvdata(dev); @@ -1088,7 +1083,6 @@ static const struct dev_pm_ops tegra234_cbb_pm = { static struct platform_driver tegra234_cbb_driver = { .probe = tegra234_cbb_probe, - .remove = tegra234_cbb_remove, .driver = { .name = "tegra234-cbb", .of_match_table = tegra234_cbb_dt_ids,
A remove callback just returning 0 is equivalent to no remove callback at all. So drop the useless function. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/soc/tegra/cbb/tegra234-cbb.c | 6 ------ 1 file changed, 6 deletions(-)