diff mbox series

[V4,6/6] dt-bindings: phy: tegra-xusb: Add support for Tegra234

Message ID 20221118154006.173082-7-jonathanh@nvidia.com
State Changes Requested
Headers show
Series Enable USB host on Jetson AGX Orin | expand

Commit Message

Jon Hunter Nov. 18, 2022, 3:40 p.m. UTC
Add the compatible string for the Tegra234 XUSB PHY.

Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
---
This is a new patch in this version of the series. This patch is
dependent upon the following patch.

https://lore.kernel.org/linux-tegra/20221118144015.3650774-1-thierry.reding@gmail.com/

 .../devicetree/bindings/phy/nvidia,tegra194-xusb-padctl.yaml  | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Rob Herring Nov. 30, 2022, 5:07 p.m. UTC | #1
On Fri, Nov 18, 2022 at 03:40:06PM +0000, Jon Hunter wrote:
> Add the compatible string for the Tegra234 XUSB PHY.
> 
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
> This is a new patch in this version of the series. This patch is
> dependent upon the following patch.
> 
> https://lore.kernel.org/linux-tegra/20221118144015.3650774-1-thierry.reding@gmail.com/
> 
>  .../devicetree/bindings/phy/nvidia,tegra194-xusb-padctl.yaml  | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/phy/nvidia,tegra194-xusb-padctl.yaml b/Documentation/devicetree/bindings/phy/nvidia,tegra194-xusb-padctl.yaml
> index 1c570ff65eb4..5302fdb0949c 100644
> --- a/Documentation/devicetree/bindings/phy/nvidia,tegra194-xusb-padctl.yaml
> +++ b/Documentation/devicetree/bindings/phy/nvidia,tegra194-xusb-padctl.yaml
> @@ -42,7 +42,9 @@ description:
>  
>  properties:
>    compatible:
> -    const: nvidia,tegra194-xusb-padctl
> +    enum:
> +      - nvidia,tegra194-xusb-padctl
> +      - nvidia,tegra194-xusb-padctl

Did you test this because I'm pretty sure you would get an error. The 
bot didn't test because of the dependency.

Rob
Jon Hunter Dec. 2, 2022, 9:53 a.m. UTC | #2
On 30/11/2022 17:07, Rob Herring wrote:
> On Fri, Nov 18, 2022 at 03:40:06PM +0000, Jon Hunter wrote:
>> Add the compatible string for the Tegra234 XUSB PHY.
>>
>> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
>> ---
>> This is a new patch in this version of the series. This patch is
>> dependent upon the following patch.
>>
>> https://lore.kernel.org/linux-tegra/20221118144015.3650774-1-thierry.reding@gmail.com/
>>
>>   .../devicetree/bindings/phy/nvidia,tegra194-xusb-padctl.yaml  | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/phy/nvidia,tegra194-xusb-padctl.yaml b/Documentation/devicetree/bindings/phy/nvidia,tegra194-xusb-padctl.yaml
>> index 1c570ff65eb4..5302fdb0949c 100644
>> --- a/Documentation/devicetree/bindings/phy/nvidia,tegra194-xusb-padctl.yaml
>> +++ b/Documentation/devicetree/bindings/phy/nvidia,tegra194-xusb-padctl.yaml
>> @@ -42,7 +42,9 @@ description:
>>   
>>   properties:
>>     compatible:
>> -    const: nvidia,tegra194-xusb-padctl
>> +    enum:
>> +      - nvidia,tegra194-xusb-padctl
>> +      - nvidia,tegra194-xusb-padctl
> 
> Did you test this because I'm pretty sure you would get an error. The
> bot didn't test because of the dependency.


Indeed. My fault for trying to juggle too many things at once. OK will 
correct this.

Jon
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/phy/nvidia,tegra194-xusb-padctl.yaml b/Documentation/devicetree/bindings/phy/nvidia,tegra194-xusb-padctl.yaml
index 1c570ff65eb4..5302fdb0949c 100644
--- a/Documentation/devicetree/bindings/phy/nvidia,tegra194-xusb-padctl.yaml
+++ b/Documentation/devicetree/bindings/phy/nvidia,tegra194-xusb-padctl.yaml
@@ -42,7 +42,9 @@  description:
 
 properties:
   compatible:
-    const: nvidia,tegra194-xusb-padctl
+    enum:
+      - nvidia,tegra194-xusb-padctl
+      - nvidia,tegra194-xusb-padctl
 
   reg:
     items: