| Message ID | 20221117182720.2290761-4-thierry.reding@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | mmc: sdhci: Add Tegra234 support | expand |
On 17/11/22 20:27, Thierry Reding wrote: > From: Thierry Reding <treding@nvidia.com> > > Sort includes alphabetically to make it easier to add new ones > subsequently. > > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- > drivers/mmc/host/sdhci-tegra.c | 23 ++++++++++++----------- > 1 file changed, 12 insertions(+), 11 deletions(-) 12 insertions and 11 deletions because linux/bitfield.h was added. I am not super enthusiastic about reordering includes. I would advise people to text search to find an include instead. Nevertheless: Acked-by: Adrian Hunter <adrian.hunter@intel.com> > > diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c > index c71000a07656..e2a8488d4fa9 100644 > --- a/drivers/mmc/host/sdhci-tegra.c > +++ b/drivers/mmc/host/sdhci-tegra.c > @@ -3,28 +3,29 @@ > * Copyright (C) 2010 Google, Inc. > */ > > +#include <linux/bitfield.h> > +#include <linux/clk.h> > #include <linux/delay.h> > #include <linux/dma-mapping.h> > #include <linux/err.h> > -#include <linux/module.h> > +#include <linux/gpio/consumer.h> > #include <linux/init.h> > -#include <linux/iopoll.h> > -#include <linux/platform_device.h> > -#include <linux/clk.h> > #include <linux/io.h> > -#include <linux/of.h> > +#include <linux/iopoll.h> > +#include <linux/ktime.h> > +#include <linux/mmc/card.h> > +#include <linux/mmc/host.h> > +#include <linux/mmc/mmc.h> > +#include <linux/mmc/slot-gpio.h> > +#include <linux/module.h> > #include <linux/of_device.h> > +#include <linux/of.h> > #include <linux/pinctrl/consumer.h> > +#include <linux/platform_device.h> > #include <linux/pm_opp.h> > #include <linux/pm_runtime.h> > #include <linux/regulator/consumer.h> > #include <linux/reset.h> > -#include <linux/mmc/card.h> > -#include <linux/mmc/host.h> > -#include <linux/mmc/mmc.h> > -#include <linux/mmc/slot-gpio.h> > -#include <linux/gpio/consumer.h> > -#include <linux/ktime.h> > > #include <soc/tegra/common.h> >
On Fri, 18 Nov 2022 at 08:33, Adrian Hunter <adrian.hunter@intel.com> wrote: > > On 17/11/22 20:27, Thierry Reding wrote: > > From: Thierry Reding <treding@nvidia.com> > > > > Sort includes alphabetically to make it easier to add new ones > > subsequently. > > > > Signed-off-by: Thierry Reding <treding@nvidia.com> > > --- > > drivers/mmc/host/sdhci-tegra.c | 23 ++++++++++++----------- > > 1 file changed, 12 insertions(+), 11 deletions(-) > > 12 insertions and 11 deletions because linux/bitfield.h > was added. > > I am not super enthusiastic about reordering includes. > I would advise people to text search to find an include > instead. Yes, I agree with you. I don't quite see the benefit. On the other hand, I don't want to waste my time on discussing it (I just did!?), as it's (currently) not that such a big deal, I think. [...] Kind regards Uffe
diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c index c71000a07656..e2a8488d4fa9 100644 --- a/drivers/mmc/host/sdhci-tegra.c +++ b/drivers/mmc/host/sdhci-tegra.c @@ -3,28 +3,29 @@ * Copyright (C) 2010 Google, Inc. */ +#include <linux/bitfield.h> +#include <linux/clk.h> #include <linux/delay.h> #include <linux/dma-mapping.h> #include <linux/err.h> -#include <linux/module.h> +#include <linux/gpio/consumer.h> #include <linux/init.h> -#include <linux/iopoll.h> -#include <linux/platform_device.h> -#include <linux/clk.h> #include <linux/io.h> -#include <linux/of.h> +#include <linux/iopoll.h> +#include <linux/ktime.h> +#include <linux/mmc/card.h> +#include <linux/mmc/host.h> +#include <linux/mmc/mmc.h> +#include <linux/mmc/slot-gpio.h> +#include <linux/module.h> #include <linux/of_device.h> +#include <linux/of.h> #include <linux/pinctrl/consumer.h> +#include <linux/platform_device.h> #include <linux/pm_opp.h> #include <linux/pm_runtime.h> #include <linux/regulator/consumer.h> #include <linux/reset.h> -#include <linux/mmc/card.h> -#include <linux/mmc/host.h> -#include <linux/mmc/mmc.h> -#include <linux/mmc/slot-gpio.h> -#include <linux/gpio/consumer.h> -#include <linux/ktime.h> #include <soc/tegra/common.h>