| Message ID | 20221109141852.729246-3-luca.ceresoli@bootlin.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add Tegra20 parallel video input capture | expand |
On 09/11/2022 15:18, luca.ceresoli@bootlin.com wrote: > From: Luca Ceresoli <luca.ceresoli@bootlin.com> > > The Tegra20 VI peripheral can receive parallel input from the VIP parallel > input module. Add it to the allowed properties and augment the existing > nvidia,tegra20-vi example to show a 'vip' property. > > Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com> > --- > .../display/tegra/nvidia,tegra20-vi.yaml | 68 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 69 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vi.yaml b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vi.yaml > index 782a4b10150a..aab795241dd6 100644 > --- a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vi.yaml > +++ b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vi.yaml > @@ -74,6 +74,22 @@ properties: > avdd-dsi-csi-supply: > description: DSI/CSI power supply. Must supply 1.2 V. > > + vip: > + $ref: /schemas/display/tegra/nvidia,tegra20-vip.yaml > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Input from the VIP (parallel input capture) module > + > + properties: > + endpoint: > + $ref: /schemas/graph.yaml#/properties/endpoint > + > patternProperties: > "^csi@[0-9a-f]+$": > type: object > @@ -109,6 +125,22 @@ examples: > #include <dt-bindings/clock/tegra20-car.h> > #include <dt-bindings/interrupt-controller/arm-gic.h> > > + i2c3 { Just "i2c" With above: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vi.yaml b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vi.yaml index 782a4b10150a..aab795241dd6 100644 --- a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vi.yaml +++ b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vi.yaml @@ -74,6 +74,22 @@ properties: avdd-dsi-csi-supply: description: DSI/CSI power supply. Must supply 1.2 V. + vip: + $ref: /schemas/display/tegra/nvidia,tegra20-vip.yaml + + ports: + $ref: /schemas/graph.yaml#/properties/ports + + properties: + port@0: + $ref: /schemas/graph.yaml#/properties/port + description: + Input from the VIP (parallel input capture) module + + properties: + endpoint: + $ref: /schemas/graph.yaml#/properties/endpoint + patternProperties: "^csi@[0-9a-f]+$": type: object @@ -109,6 +125,22 @@ examples: #include <dt-bindings/clock/tegra20-car.h> #include <dt-bindings/interrupt-controller/arm-gic.h> + i2c3 { + #address-cells = <1>; + #size-cells = <0>; + camera@48 { + compatible = "aptina,mt9v111"; + reg = <0x48>; + clocks = <&camera_clk>; + + port { + mt9v111_out: endpoint { + remote-endpoint = <&vi_vip_in>; + }; + }; + }; + }; + vi@54080000 { compatible = "nvidia,tegra20-vi"; reg = <0x54080000 0x00040000>; @@ -116,6 +148,42 @@ examples: clocks = <&tegra_car TEGRA20_CLK_VI>; resets = <&tegra_car 100>; reset-names = "vi"; + + vip { + compatible = "nvidia,tegra20-vip"; + #address-cells = <1>; + #size-cells = <0>; + channel@0 { + reg = <0>; + ports { + #address-cells = <1>; + #size-cells = <0>; + port@0 { + reg = <0>; + vi_vip_in: endpoint { + remote-endpoint = <&mt9v111_out>; + }; + }; + port@1 { + reg = <1>; + vi_vip_out: endpoint { + remote-endpoint = <&vi_in>; + }; + }; + }; + }; + }; + + ports { + #address-cells = <1>; + #size-cells = <0>; + port@0 { + reg = <0>; + vi_in: endpoint { + remote-endpoint = <&vi_vip_out>; + }; + }; + }; }; - | diff --git a/MAINTAINERS b/MAINTAINERS index b43f6f4e8ccf..0a4f66a32e45 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -20284,6 +20284,7 @@ M: Luca Ceresoli <luca.ceresoli@bootlin.com> L: linux-media@vger.kernel.org L: linux-tegra@vger.kernel.org S: Maintained +F: Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vi.yaml F: Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vip.yaml TEGRA XUSB PADCTL DRIVER