| Message ID | 20221027065625.1443750-1-yangyingliang@huawei.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [-next] soc/tegra: cbb: tegra194: use of_address_count() helper | expand |
On Thu, Oct 27, 2022 at 02:56:25PM +0800, Yang Yingliang wrote: > After commit 16988c742968 ("of/address: introduce of_address_count() helper"), > We can use of_address_count() to instead of open-coding it. > > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > --- > drivers/soc/tegra/cbb/tegra194-cbb.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) That commit is only in linux-next for now, so I can't apply this yet. Thierry
From: Thierry Reding <treding@nvidia.com> On Thu, 27 Oct 2022 14:56:25 +0800, Yang Yingliang wrote: > After commit 16988c742968 ("of/address: introduce of_address_count() helper"), > We can use of_address_count() to instead of open-coding it. > > Applied, thanks! [1/1] soc/tegra: cbb: tegra194: use of_address_count() helper (no commit info) Best regards,
diff --git a/drivers/soc/tegra/cbb/tegra194-cbb.c b/drivers/soc/tegra/cbb/tegra194-cbb.c index 1ae0bd9a1ac1..b5676dd49e88 100644 --- a/drivers/soc/tegra/cbb/tegra194-cbb.c +++ b/drivers/soc/tegra/cbb/tegra194-cbb.c @@ -2191,7 +2191,6 @@ MODULE_DEVICE_TABLE(of, tegra194_cbb_match); static int tegra194_cbb_get_bridges(struct tegra194_cbb *cbb, struct device_node *np) { struct tegra_cbb *entry; - struct resource res; unsigned long flags; unsigned int i; int err; @@ -2211,8 +2210,7 @@ static int tegra194_cbb_get_bridges(struct tegra194_cbb *cbb, struct device_node spin_unlock_irqrestore(&cbb_lock, flags); if (!cbb->bridges) { - while (of_address_to_resource(np, cbb->num_bridges, &res) == 0) - cbb->num_bridges++; + cbb->num_bridges = of_address_count(np); cbb->bridges = devm_kcalloc(cbb->base.dev, cbb->num_bridges, sizeof(*cbb->bridges), GFP_KERNEL);
After commit 16988c742968 ("of/address: introduce of_address_count() helper"), We can use of_address_count() to instead of open-coding it. Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/soc/tegra/cbb/tegra194-cbb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)