diff mbox series

[5/5] dt-bindings: arm: tegra: Add missing compatible strings

Message ID 20220711152020.688461-5-thierry.reding@gmail.com
State Changes Requested
Headers show
Series [1/5] dt-bindings: arm: tegra: flowctrl: Convert to json-schema | expand

Commit Message

Thierry Reding July 11, 2022, 3:20 p.m. UTC 
From: Thierry Reding <treding@nvidia.com>

The Nyan Blaze and Nyan Big, as well as Jetson Nano (P3450-0000), Darcy
(P2894-0050-A08) and Pixel C (Smaug) were never mentioned. Add them.

While at it, also fix a typo in the compatible string for Apalis Tegra30
v1.1 evaluation board.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 .../devicetree/bindings/arm/tegra.yaml        | 50 ++++++++++++++++++-
 1 file changed, 48 insertions(+), 2 deletions(-)

Comments

Francesco Dolcini July 11, 2022, 3:36 p.m. UTC | #1 
Hello Thierry

On Mon, Jul 11, 2022 at 05:20:20PM +0200, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> While at it, also fix a typo in the compatible string for Apalis Tegra30
> v1.1 evaluation board.

Appreciated! Maybe you can double check the Apalis change? I cannot see any
related change in the patch.

Francesco
Thierry Reding July 11, 2022, 4:41 p.m. UTC | #2 
On Mon, Jul 11, 2022 at 05:36:43PM +0200, Francesco Dolcini wrote:
> Hello Thierry
> 
> On Mon, Jul 11, 2022 at 05:20:20PM +0200, Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> > 
> > While at it, also fix a typo in the compatible string for Apalis Tegra30
> > v1.1 evaluation board.
> 
> Appreciated! Maybe you can double check the Apalis change? I cannot see any
> related change in the patch.

Heh... looks like this was already fixed by David almost a year ago:

	commit 55c21d57eafb7b379bb7b3e93baf9ca2695895b0
	Author: David Heidelberg <david@ixit.cz>
	Date:   Sun Sep 12 18:51:20 2021 +0200

	    dt-bindings: arm: Fix Toradex compatible typo
	    
	    Fix board compatible typo reported by dtbs_check.
	    
	    Fixes: f4d1577e9bc6 ("dt-bindings: arm: Convert Tegra board/soc bindings to json-schema")
	    Signed-off-by: David Heidelberg <david@ixit.cz>
	    Link: https://lore.kernel.org/r/20210912165120.188490-1-david@ixit.cz
	    Signed-off-by: Rob Herring <robh@kernel.org>

Clearly I have been carrying these patches locally for way too long...

Thanks for noticing, I'll drop that comment from the commit message.

Thierry
Krzysztof Kozlowski July 12, 2022, 8:30 a.m. UTC | #3 
On 11/07/2022 17:20, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> The Nyan Blaze and Nyan Big, as well as Jetson Nano (P3450-0000), Darcy
> (P2894-0050-A08) and Pixel C (Smaug) were never mentioned. Add them.
> 
> While at it, also fix a typo in the compatible string for Apalis Tegra30
> v1.1 evaluation board.
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>



Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/tegra.yaml b/Documentation/devicetree/bindings/arm/tegra.yaml
index 49841ca272ee..187d832a14ac 100644
--- a/Documentation/devicetree/bindings/arm/tegra.yaml
+++ b/Documentation/devicetree/bindings/arm/tegra.yaml
@@ -114,6 +114,33 @@  properties:
           - const: toradex,apalis-tk1-v1.2
           - const: toradex,apalis-tk1
           - const: nvidia,tegra124
+      - items:
+          - const: google,nyan-big-rev7
+          - const: google,nyan-big-rev6
+          - const: google,nyan-big-rev5
+          - const: google,nyan-big-rev4
+          - const: google,nyan-big-rev3
+          - const: google,nyan-big-rev2
+          - const: google,nyan-big-rev1
+          - const: google,nyan-big-rev0
+          - const: google,nyan-big
+          - const: google,nyan
+          - const: nvidia,tegra124
+      - items:
+          - const: google,nyan-blaze-rev10
+          - const: google,nyan-blaze-rev9
+          - const: google,nyan-blaze-rev8
+          - const: google,nyan-blaze-rev7
+          - const: google,nyan-blaze-rev6
+          - const: google,nyan-blaze-rev5
+          - const: google,nyan-blaze-rev4
+          - const: google,nyan-blaze-rev3
+          - const: google,nyan-blaze-rev2
+          - const: google,nyan-blaze-rev1
+          - const: google,nyan-blaze-rev0
+          - const: google,nyan-blaze
+          - const: google,nyan
+          - const: nvidia,tegra124
       - items:
           - enum:
               - nvidia,norrin
@@ -121,11 +148,30 @@  properties:
           - const: nvidia,tegra124
       - items:
           - enum:
-              - nvidia,darcy
               - nvidia,p2371-0000
               - nvidia,p2371-2180
               - nvidia,p2571
-              - nvidia,p2894-0050-a08
+          - const: nvidia,tegra210
+      - description: NVIDIA Jetson Nano
+        items:
+          - const: nvidia,p3450-0000
+          - const: nvidia,tegra210
+      - description: NVIDIA Shield TV
+        items:
+          - const: nvidia,p2894-0050-a08
+          - const: nvidia,darcy
+          - const: nvidia,tegra210
+      - description: Google Pixel C
+        items:
+          - const: google,smaug-rev8
+          - const: google,smaug-rev7
+          - const: google,smaug-rev6
+          - const: google,smaug-rev5
+          - const: google,smaug-rev4
+          - const: google,smaug-rev3
+          - const: google,smaug-rev2
+          - const: google,smaug-rev1
+          - const: google,smaug
           - const: nvidia,tegra210
       - description: Jetson TX2 Developer Kit
         items: