diff mbox series

[net-next,v1,3/9] dt-bindings: memory: Add Tegra234 MGBE memory clients

Message ID 20220623074615.56418-3-vbhadram@nvidia.com
State Changes Requested
Headers show
Series [net-next,v1,1/9] dt-bindings: power: Add Tegra234 MGBE power domains | expand

Commit Message

Bhadram Varka June 23, 2022, 7:46 a.m. UTC 
From: Thierry Reding <treding@nvidia.com>

Add the memory client and stream ID definitions for the MGBE hardware
found on Tegra234 SoCs.

Signed-off-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Bhadram Varka <vbhadram@nvidia.com>
---
 include/dt-bindings/memory/tegra234-mc.h | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

Comments

Krzysztof Kozlowski June 24, 2022, 4:06 p.m. UTC | #1 
On Thu, 23 Jun 2022 13:16:09 +0530, Bhadram Varka wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> Add the memory client and stream ID definitions for the MGBE hardware
> found on Tegra234 SoCs.
> 
> 

Applied, thanks!

[3/9] dt-bindings: memory: Add Tegra234 MGBE memory clients
      https://git.kernel.org/krzk/linux-mem-ctrl/c/f35756b5fc488912b8bc5f5686e4f236d00923d7

Best regards,
Krzysztof Kozlowski June 24, 2022, 4:10 p.m. UTC | #2 
On 24/06/2022 18:06, Krzysztof Kozlowski wrote:
> On Thu, 23 Jun 2022 13:16:09 +0530, Bhadram Varka wrote:
>> From: Thierry Reding <treding@nvidia.com>
>>
>> Add the memory client and stream ID definitions for the MGBE hardware
>> found on Tegra234 SoCs.
>>
>>
> 
> Applied, thanks!
> 
> [3/9] dt-bindings: memory: Add Tegra234 MGBE memory clients
>       https://git.kernel.org/krzk/linux-mem-ctrl/c/f35756b5fc488912b8bc5f5686e4f236d00923d7
> 

Hmm, actually now I think you might need it for DTS, although there was
no cover letter here explaining merging/dependencies...

I could provide you a tag with it or opposite (take a tag with only the
header).

Best regards,
Krzysztof
Thierry Reding June 24, 2022, 4:19 p.m. UTC | #3 
On Fri, Jun 24, 2022 at 06:10:54PM +0200, Krzysztof Kozlowski wrote:
> On 24/06/2022 18:06, Krzysztof Kozlowski wrote:
> > On Thu, 23 Jun 2022 13:16:09 +0530, Bhadram Varka wrote:
> >> From: Thierry Reding <treding@nvidia.com>
> >>
> >> Add the memory client and stream ID definitions for the MGBE hardware
> >> found on Tegra234 SoCs.
> >>
> >>
> > 
> > Applied, thanks!
> > 
> > [3/9] dt-bindings: memory: Add Tegra234 MGBE memory clients
> >       https://git.kernel.org/krzk/linux-mem-ctrl/c/f35756b5fc488912b8bc5f5686e4f236d00923d7
> > 
> 
> Hmm, actually now I think you might need it for DTS, although there was
> no cover letter here explaining merging/dependencies...
> 
> I could provide you a tag with it or opposite (take a tag with only the
> header).

I can pick this up into the Tegra tree where I already carry an earlier
patch for Tegra234 GPCDMA that you had acked. That works better for this
model since, as you said, this is needed as a dependency for the DTS
files.

Thierry
Krzysztof Kozlowski June 25, 2022, 8:18 p.m. UTC | #4 
On 23/06/2022 09:46, Bhadram Varka wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> Add the memory client and stream ID definitions for the MGBE hardware
> found on Tegra234 SoCs.
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> Signed-off-by: Bhadram Varka <vbhadram@nvidia.com>


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Dropped from my tree.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/include/dt-bindings/memory/tegra234-mc.h b/include/dt-bindings/memory/tegra234-mc.h
index e3b0e9da295d..8b0ddcb715ff 100644
--- a/include/dt-bindings/memory/tegra234-mc.h
+++ b/include/dt-bindings/memory/tegra234-mc.h
@@ -11,11 +11,16 @@ 
 /* NISO0 stream IDs */
 #define TEGRA234_SID_APE	0x02
 #define TEGRA234_SID_HDA	0x03
+#define TEGRA234_SID_GPCDMA	0x04
+#define TEGRA234_SID_MGBE	0x06
 #define TEGRA234_SID_PCIE0	0x12
 #define TEGRA234_SID_PCIE4	0x13
 #define TEGRA234_SID_PCIE5	0x14
 #define TEGRA234_SID_PCIE6	0x15
 #define TEGRA234_SID_PCIE9	0x1f
+#define TEGRA234_SID_MGBE_VF1	0x49
+#define TEGRA234_SID_MGBE_VF2	0x4a
+#define TEGRA234_SID_MGBE_VF3	0x4b
 
 /* NISO1 stream IDs */
 #define TEGRA234_SID_SDMMC4	0x02
@@ -61,8 +66,24 @@ 
 #define TEGRA234_MEMORY_CLIENT_PCIE10AR1 0x48
 /* PCIE7r1 read clients */
 #define TEGRA234_MEMORY_CLIENT_PCIE7AR1 0x49
+/* MGBE0 read client */
+#define TEGRA234_MEMORY_CLIENT_MGBEARD 0x58
+/* MGBEB read client */
+#define TEGRA234_MEMORY_CLIENT_MGBEBRD 0x59
+/* MGBEC read client */
+#define TEGRA234_MEMORY_CLIENT_MGBECRD 0x5a
+/* MGBED read client */
+#define TEGRA234_MEMORY_CLIENT_MGBEDRD 0x5b
+/* MGBE0 write client */
+#define TEGRA234_MEMORY_CLIENT_MGBEAWR 0x5c
+/* MGBEB write client */
+#define TEGRA234_MEMORY_CLIENT_MGBEBWR 0x5f
+/* MGBEC write client */
+#define TEGRA234_MEMORY_CLIENT_MGBECWR 0x61
 /* sdmmcd memory read client */
 #define TEGRA234_MEMORY_CLIENT_SDMMCRAB 0x63
+/* MGBED write client */
+#define TEGRA234_MEMORY_CLIENT_MGBEDWR 0x65
 /* sdmmcd memory write client */
 #define TEGRA234_MEMORY_CLIENT_SDMMCWAB 0x67
 /* BPMP read client */