| Message ID | 20220107082436.17716-1-linmq006@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | clk: tegra: tegra124-emc: Fix missing put_device() call in emc_ensure_emc_driver | expand |
Quoting Miaoqian Lin (2022-01-07 00:24:36) > The reference taken by 'of_find_device_by_node()' must be released when > not needed anymore. > Add the corresponding 'put_device()' in the error handling path. > > Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Please send the mail To: somebody Also, please add a Fixes: tag.
diff --git a/drivers/clk/tegra/clk-tegra124-emc.c b/drivers/clk/tegra/clk-tegra124-emc.c index 74c1d894cca8..219c80653dbd 100644 --- a/drivers/clk/tegra/clk-tegra124-emc.c +++ b/drivers/clk/tegra/clk-tegra124-emc.c @@ -198,6 +198,7 @@ static struct tegra_emc *emc_ensure_emc_driver(struct tegra_clk_emc *tegra) tegra->emc = platform_get_drvdata(pdev); if (!tegra->emc) { + put_device(&pdev->dev); pr_err("%s: cannot find EMC driver\n", __func__); return NULL; }
The reference taken by 'of_find_device_by_node()' must be released when not needed anymore. Add the corresponding 'put_device()' in the error handling path. Signed-off-by: Miaoqian Lin <linmq006@gmail.com> --- drivers/clk/tegra/clk-tegra124-emc.c | 1 + 1 file changed, 1 insertion(+)