diff mbox series

[v1,2/2] spi: tegra20-slink: Don't use resource-managed spi_register helper

Message ID 20210731191458.30535-2-digetx@gmail.com
State Changes Requested
Headers show
Series [v1,1/2] spi: tegra20-slink: Improve runtime PM usage | expand

Commit Message

Dmitry Osipenko July 31, 2021, 7:14 p.m. UTC 
Don't use resource-managed spi_register helper to correct the driver
removal order and fix memory leak of spi_master that is never released.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/spi/spi-tegra20-slink.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comments

Dmitry Osipenko July 31, 2021, 7:21 p.m. UTC | #1 
31.07.2021 22:14, Dmitry Osipenko пишет:
> Don't use resource-managed spi_register helper to correct the driver
> removal order and fix memory leak of spi_master that is never released.

The "memory leak" isn't correct, I now see where the devm variant
releases memory. I'll make v2 with a changed commit message.
diff mbox series

Patch

diff --git a/drivers/spi/spi-tegra20-slink.c b/drivers/spi/spi-tegra20-slink.c
index 501eca1d0f89..deff16ba6d58 100644
--- a/drivers/spi/spi-tegra20-slink.c
+++ b/drivers/spi/spi-tegra20-slink.c
@@ -1112,7 +1112,7 @@  static int tegra_slink_probe(struct platform_device *pdev)
 	tegra_slink_writel(tspi, tspi->def_command2_reg, SLINK_COMMAND2);
 
 	master->dev.of_node = pdev->dev.of_node;
-	ret = devm_spi_register_master(&pdev->dev, master);
+	ret = spi_register_master(master);
 	if (ret < 0) {
 		dev_err(&pdev->dev, "can not register to master err %d\n", ret);
 		goto exit_free_irq;
@@ -1142,6 +1142,8 @@  static int tegra_slink_remove(struct platform_device *pdev)
 	struct spi_master *master = platform_get_drvdata(pdev);
 	struct tegra_slink_data	*tspi = spi_master_get_devdata(master);
 
+	spi_unregister_master(master);
+
 	free_irq(tspi->irq, tspi);
 
 	pm_runtime_disable(&pdev->dev);
@@ -1152,6 +1154,8 @@  static int tegra_slink_remove(struct platform_device *pdev)
 	if (tspi->rx_dma_chan)
 		tegra_slink_deinit_dma_param(tspi, true);
 
+	spi_master_put(master);
+
 	return 0;
 }