Message ID | 20210722090748.1157470-1-arnd@kernel.org |
---|---|
State | Accepted |
Headers | show |
Series | memory: tegra: fix unused-function warning | expand |
On 22/07/2021 10:07, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The tegra186_mc_client_sid_override() is only called from > an #ifdef block: > > drivers/memory/tegra/tegra186.c:74:13: error: 'tegra186_mc_client_sid_override' defined but not used [-Werror=unused-function] > 74 | static void tegra186_mc_client_sid_override(struct tegra_mc *mc, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Add another #ifdef around the called function. > > Fixes: 393d66fd2cac ("memory: tegra: Implement SID override programming") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/memory/tegra/tegra186.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/memory/tegra/tegra186.c b/drivers/memory/tegra/tegra186.c > index e65eac5764d4..3d153881abc1 100644 > --- a/drivers/memory/tegra/tegra186.c > +++ b/drivers/memory/tegra/tegra186.c > @@ -71,6 +71,7 @@ static int tegra186_mc_resume(struct tegra_mc *mc) > return 0; > } > > +#if IS_ENABLED(CONFIG_IOMMU_API) > static void tegra186_mc_client_sid_override(struct tegra_mc *mc, > const struct tegra_mc_client *client, > unsigned int sid) > @@ -108,6 +109,7 @@ static void tegra186_mc_client_sid_override(struct tegra_mc *mc, > writel(sid, mc->regs + client->regs.sid.override); > } > } > +#endif > > static int tegra186_mc_probe_device(struct tegra_mc *mc, struct device *dev) > { > Acked-by: Jon Hunter <jonathanh@nvidia.com> Thanks for fixing! Jon
On Thu, 22 Jul 2021 11:07:43 +0200, Arnd Bergmann wrote: > The tegra186_mc_client_sid_override() is only called from > an #ifdef block: > > drivers/memory/tegra/tegra186.c:74:13: error: 'tegra186_mc_client_sid_override' defined but not used [-Werror=unused-function] > 74 | static void tegra186_mc_client_sid_override(struct tegra_mc *mc, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > [...] Applied, thanks! [1/1] memory: tegra: fix unused-function warning commit: eaf89f1cd38cf7256ab64424fe94014632044d57 Best regards,
diff --git a/drivers/memory/tegra/tegra186.c b/drivers/memory/tegra/tegra186.c index e65eac5764d4..3d153881abc1 100644 --- a/drivers/memory/tegra/tegra186.c +++ b/drivers/memory/tegra/tegra186.c @@ -71,6 +71,7 @@ static int tegra186_mc_resume(struct tegra_mc *mc) return 0; } +#if IS_ENABLED(CONFIG_IOMMU_API) static void tegra186_mc_client_sid_override(struct tegra_mc *mc, const struct tegra_mc_client *client, unsigned int sid) @@ -108,6 +109,7 @@ static void tegra186_mc_client_sid_override(struct tegra_mc *mc, writel(sid, mc->regs + client->regs.sid.override); } } +#endif static int tegra186_mc_probe_device(struct tegra_mc *mc, struct device *dev) {