| Message ID | 20190529102654.14665-1-thierry.reding@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/2] soc/tegra: pmc: Fail to allocate more than one wake IRQ | expand |
On 29/05/2019 11:26, Thierry Reding wrote: > From: Thierry Reding <treding@nvidia.com> > > The code currently doesn't support allocating more than one wake IRQ at > a time. Detect this situation and error out. Also make sure to output a > warning when that happens to help track down callers. > > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- > drivers/soc/tegra/pmc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c > index 5648e5c09ef5..653fe2c466f6 100644 > --- a/drivers/soc/tegra/pmc.c > +++ b/drivers/soc/tegra/pmc.c > @@ -1863,6 +1863,9 @@ static int tegra_pmc_irq_alloc(struct irq_domain *domain, unsigned int virq, > unsigned int i; > int err = 0; > > + if (WARN_ON(num_irqs > 1)) > + return -EINVAL; > + > for (i = 0; i < soc->num_wake_events; i++) { > const struct tegra_wake_event *event = &soc->wake_events[i]; Acked-by: Jon Hunter <jonathanh@nvidia.com> Cheers Jon
diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c index 5648e5c09ef5..653fe2c466f6 100644 --- a/drivers/soc/tegra/pmc.c +++ b/drivers/soc/tegra/pmc.c @@ -1863,6 +1863,9 @@ static int tegra_pmc_irq_alloc(struct irq_domain *domain, unsigned int virq, unsigned int i; int err = 0; + if (WARN_ON(num_irqs > 1)) + return -EINVAL; + for (i = 0; i < soc->num_wake_events; i++) { const struct tegra_wake_event *event = &soc->wake_events[i];