| Message ID | 20190131092410.28222-7-josephl@nvidia.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add CPUidle support for Tegra210 | expand |
On Thu, Jan 31, 2019 at 05:24:09PM +0800, Joseph Lo wrote: > Enable CPU idle support for Jetson TX1 platform. > > Signed-off-by: Joseph Lo <josephl@nvidia.com> > --- > v4: > * no change > v3: > * no change > v2: > * no change > --- > arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi b/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi > index 053458a5db55..d1a492c63e96 100644 > --- a/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi > +++ b/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi > @@ -305,6 +305,12 @@ > cpu@3 { > enable-method = "psci"; > }; > + > + idle-states { > + c7 { > + status = "okay"; Doesn't seem like the code currently cares, but the bindings are specific, so this looks good to me. Given that we need the timer in order to get out of this state, I'm assuming that I should hold back on these patches until the driver changes have been merged to make sure we don't regress. Is that correct? Thierry
On 1/31/19 8:57 PM, Thierry Reding wrote: > On Thu, Jan 31, 2019 at 05:24:09PM +0800, Joseph Lo wrote: >> Enable CPU idle support for Jetson TX1 platform. >> >> Signed-off-by: Joseph Lo <josephl@nvidia.com> >> --- >> v4: >> * no change >> v3: >> * no change >> v2: >> * no change >> --- >> arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi b/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi >> index 053458a5db55..d1a492c63e96 100644 >> --- a/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi >> +++ b/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi >> @@ -305,6 +305,12 @@ >> cpu@3 { >> enable-method = "psci"; >> }; >> + >> + idle-states { >> + c7 { >> + status = "okay"; > > Doesn't seem like the code currently cares, but the bindings are > specific, so this looks good to me. > > Given that we need the timer in order to get out of this state, I'm > assuming that I should hold back on these patches until the driver > changes have been merged to make sure we don't regress. Is that > correct? > Yes, correct. Need to make sure all the timer related stuff landed first. Thanks, Joseph
diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi b/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi index 053458a5db55..d1a492c63e96 100644 --- a/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi +++ b/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi @@ -305,6 +305,12 @@ cpu@3 { enable-method = "psci"; }; + + idle-states { + c7 { + status = "okay"; + }; + }; }; psci {
Enable CPU idle support for Jetson TX1 platform. Signed-off-by: Joseph Lo <josephl@nvidia.com> --- v4: * no change v3: * no change v2: * no change --- arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi | 6 ++++++ 1 file changed, 6 insertions(+)