From patchwork Mon Nov 12 15:18:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thierry Reding X-Patchwork-Id: 996486 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-tegra-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="iBXgZ8Cz"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42tvYK1htWz9s3C for ; Tue, 13 Nov 2018 02:19:01 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729452AbeKMBMk (ORCPT ); Mon, 12 Nov 2018 20:12:40 -0500 Received: from mail-ed1-f67.google.com ([209.85.208.67]:40503 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726443AbeKMBMk (ORCPT ); Mon, 12 Nov 2018 20:12:40 -0500 Received: by mail-ed1-f67.google.com with SMTP id d3so7089933edx.7; Mon, 12 Nov 2018 07:18:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UzI7QItBboJycH/HpslvTFG94WVjeSBxpsz6zXZa7wE=; b=iBXgZ8CzGcK6Z4IAwmgQZF+n+el0Kchck8L0NZMQ8lQs0OVmOIR+Qx4xx+SJiNIRIP WMKHcWYojcDEqUkc99JYn+AIhwTNaNjwH9LBPIjjIb5UNmm+2li76cJOG3Mph7CDLAd7 71h5Zo1kOQ2dI/3TgvoeXIHIQBra5bmOB2GFbF1XzDCte9tLeWgBmf8GDvOHJcHNzza3 afGOYfmnx3qGODEnwzbsP8bpBjOOUIJeYhUptduoIpwMXor6n1C1mP50xdKirwUeZh68 +nDqXmKEj8Uoj05IFyitPe/WXPfd9kdsPdAvmdCAV/3JOMuYHzYVwcp0Tt6FCclIaf54 0SXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=UzI7QItBboJycH/HpslvTFG94WVjeSBxpsz6zXZa7wE=; b=MNE4vE3hAQRMXLOvg4zvCm8bEVqVbA2Jf5za0bk8AfIXEjFimmdFOx4qpdL9kpsb42 XWZGfPVVuB2V+ABVN5Lf7SRF3TquiENUoiat16aHAw2OPE0tuYWvdMF6eaoKPAt3QzZv bWzRZDRRcR1vcXMRlPaDO1FJScYsFHvEkMjedQBVGj1TbbcSPS7XMr+cEjyIAjmQtHB8 2FpJbzj8bqfuXWwulI7TTa1Ya4NYB20E+74xa2FA7jVjWyqH29YGbP9EG+pfQUSlIvhg /SPizzM2LUVl+KmeG16OQtIaswWDlze343bUrwAcHP9ewnGVG9zGIRwViOZ3E6WOegwU kaJg== X-Gm-Message-State: AGRZ1gJx08Znw9w7uzdMjLocMdbEa6qKOCbzOM6JJBUEDVTKMY7BxfSg Td2wD/ZWouI8lyT9u3u/RQI= X-Google-Smtp-Source: AJdET5dWj6hZvnuwkvzovvkxCw3BpZVHWPCUBW8bwGFsS5NoRr4JzGHmCMpW1mhOLLnhc98kleGtrg== X-Received: by 2002:a50:a985:: with SMTP id n5-v6mr13033559edc.120.1542035937258; Mon, 12 Nov 2018 07:18:57 -0800 (PST) Received: from localhost (pD9E511F8.dip0.t-ipconnect.de. [217.229.17.248]) by smtp.gmail.com with ESMTPSA id s9-v6sm2396809ejf.27.2018.11.12.07.18.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 12 Nov 2018 07:18:56 -0800 (PST) From: Thierry Reding To: Thierry Reding , Jassi Brar , Greg Kroah-Hartman Cc: Jiri Slaby , Mikko Perttunen , Jon Hunter , Timo Alho , Pekka Pessi , Mika Liljeberg , linux-tegra@vger.kernel.org, linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 01/10] mailbox: Support blocking transfers in atomic context Date: Mon, 12 Nov 2018 16:18:44 +0100 Message-Id: <20181112151853.29289-2-thierry.reding@gmail.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181112151853.29289-1-thierry.reding@gmail.com> References: <20181112151853.29289-1-thierry.reding@gmail.com> MIME-Version: 1.0 Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org From: Thierry Reding The mailbox framework supports blocking transfers via completions for clients that can sleep. In order to support blocking transfers in cases where the transmission is not permitted to sleep, add a new ->flush() callback that controller drivers can implement to busy loop until the transmission has been completed. This will automatically be called when available and interrupts are disabled for clients that request blocking transfers. Signed-off-by: Thierry Reding --- drivers/mailbox/mailbox.c | 8 ++++++++ include/linux/mailbox_controller.h | 4 ++++ 2 files changed, 12 insertions(+) diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c index 674b35f402f5..0eaf21259874 100644 --- a/drivers/mailbox/mailbox.c +++ b/drivers/mailbox/mailbox.c @@ -267,6 +267,14 @@ int mbox_send_message(struct mbox_chan *chan, void *mssg) unsigned long wait; int ret; + if (irqs_disabled() && chan->mbox->ops->flush) { + ret = chan->mbox->ops->flush(chan, chan->cl->tx_tout); + if (ret < 0) + tx_tick(chan, ret); + + return ret; + } + if (!chan->cl->tx_tout) /* wait forever */ wait = msecs_to_jiffies(3600000); else diff --git a/include/linux/mailbox_controller.h b/include/linux/mailbox_controller.h index 74deadb42d76..2a07d93f781a 100644 --- a/include/linux/mailbox_controller.h +++ b/include/linux/mailbox_controller.h @@ -24,6 +24,9 @@ struct mbox_chan; * transmission of data is reported by the controller via * mbox_chan_txdone (if it has some TX ACK irq). It must not * sleep. + * @flush: Called when a client requests transmissions to be blocking but + * the context doesn't allow sleeping. Typically the controller + * will implement a busy loop waiting for the data to flush out. * @startup: Called when a client requests the chan. The controller * could ask clients for additional parameters of communication * to be provided via client's chan_data. This call may @@ -46,6 +49,7 @@ struct mbox_chan; */ struct mbox_chan_ops { int (*send_data)(struct mbox_chan *chan, void *data); + int (*flush)(struct mbox_chan *chan, unsigned long timeout); int (*startup)(struct mbox_chan *chan); void (*shutdown)(struct mbox_chan *chan); bool (*last_tx_done)(struct mbox_chan *chan);