diff mbox series

apalis_t30: fix can2

Message ID 20180625075948.32040-1-marcel@ziswiler.com
State Superseded
Headers show
Series apalis_t30: fix can2 | expand

Commit Message

Marcel Ziswiler June 25, 2018, 7:59 a.m. UTC 
From: Marcel Ziswiler <marcel.ziswiler@toradex.com>

CAN2 currently fails on probe as follows:

mcp251x spi1.1: Probe failed, err=19

Fix this by enabling input on pin mux of resp. SPI4 pins.

Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>

---

 arch/arm/boot/dts/tegra30-apalis.dtsi | 1 +
 1 file changed, 1 insertion(+)

Comments

Marc Kleine-Budde July 23, 2018, 8:16 a.m. UTC | #1 
On 06/25/2018 09:59 AM, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> 
> CAN2 currently fails on probe as follows:
> 
> mcp251x spi1.1: Probe failed, err=19
> 
> Fix this by enabling input on pin mux of resp. SPI4 pins.
> 
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>

I can take this via the linux-can tree. Any acks from the DT people?

Marc

> 
> ---
> 
>  arch/arm/boot/dts/tegra30-apalis.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/tegra30-apalis.dtsi b/arch/arm/boot/dts/tegra30-apalis.dtsi
> index d1d21ec2a844..9ff6aafd72b3 100644
> --- a/arch/arm/boot/dts/tegra30-apalis.dtsi
> +++ b/arch/arm/boot/dts/tegra30-apalis.dtsi
> @@ -118,6 +118,7 @@
>  				nvidia,function = "spi4";
>  				nvidia,pull = <TEGRA_PIN_PULL_NONE>;
>  				nvidia,tristate = <TEGRA_PIN_DISABLE>;
> +				nvidia,enable-input = <TEGRA_PIN_ENABLE>;
>  			};
>  			/* CAN_INT2 */
>  			spi2_cs2_n_pw3 {
>
Marc Kleine-Budde July 23, 2018, 10:18 a.m. UTC | #2 
On 07/23/2018 10:16 AM, Marc Kleine-Budde wrote:
> On 06/25/2018 09:59 AM, Marcel Ziswiler wrote:
>> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>>
>> CAN2 currently fails on probe as follows:
>>
>> mcp251x spi1.1: Probe failed, err=19
>>
>> Fix this by enabling input on pin mux of resp. SPI4 pins.
>>
>> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> 
> I can take this via the linux-can tree. Any acks from the DT people?

Never mind - it has been applied by Thierry menawhile:

> Applied to for-4.19/arm/dt, thanks.
> 
> Thierry

sorry for the noise.
Marc
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/tegra30-apalis.dtsi b/arch/arm/boot/dts/tegra30-apalis.dtsi
index d1d21ec2a844..9ff6aafd72b3 100644
--- a/arch/arm/boot/dts/tegra30-apalis.dtsi
+++ b/arch/arm/boot/dts/tegra30-apalis.dtsi
@@ -118,6 +118,7 @@ 
 				nvidia,function = "spi4";
 				nvidia,pull = <TEGRA_PIN_PULL_NONE>;
 				nvidia,tristate = <TEGRA_PIN_DISABLE>;
+				nvidia,enable-input = <TEGRA_PIN_ENABLE>;
 			};
 			/* CAN_INT2 */
 			spi2_cs2_n_pw3 {