diff mbox series

[2/4] ASoC: tegra: Fix kcontrol put callback in I2S

Message ID 1635915897-32313-3-git-send-email-spujar@nvidia.com
State Superseded
Headers show
Series Fix kcontrol put callback in Tegra drivers | expand

Commit Message

Sameer Pujar Nov. 3, 2021, 5:04 a.m. UTC 
The kcontrol put callback is expected to return 1 when there is change
in HW or when the update is acknowledged by driver. This would ensure
that change notifications are sent to subscribed applications. Update
the I2S driver accordingly.

Fixes: c0bfa98349d1 ("ASoC: tegra: Add Tegra210 based I2S driver")
Suggested-by: Jaroslav Kysela <perex@perex.cz>
Suggested-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sameer Pujar <spujar@nvidia.com>
---
 sound/soc/tegra/tegra210_i2s.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/sound/soc/tegra/tegra210_i2s.c b/sound/soc/tegra/tegra210_i2s.c
index 45f31cc..b738b21 100644
--- a/sound/soc/tegra/tegra210_i2s.c
+++ b/sound/soc/tegra/tegra210_i2s.c
@@ -380,9 +380,11 @@  static int tegra210_i2s_put_control(struct snd_kcontrol *kcontrol,
 		i2s->rx_fifo_th = value;
 	} else if (strstr(kcontrol->id.name, "BCLK Ratio")) {
 		i2s->bclk_ratio = value;
+	} else {
+		return 0;
 	}
 
-	return 0;
+	return 1;
 }
 
 static int tegra210_i2s_set_timing_params(struct device *dev,