Message ID | 1634544019-36822-1-git-send-email-wangqing@vivo.com |
---|---|
State | Superseded |
Headers | show
Return-Path: <linux-tegra-owner@vger.kernel.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=vivo0.onmicrosoft.com header.i=@vivo0.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-vivo0-onmicrosoft-com header.b=eBOYHLyY; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-tegra-owner@vger.kernel.org; receiver=<UNKNOWN>) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by bilbo.ozlabs.org (Postfix) with ESMTP id 4HXq9B4d79z9sPf for <incoming@patchwork.ozlabs.org>; Mon, 18 Oct 2021 19:02:22 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230523AbhJRIE3 (ORCPT <rfc822;incoming@patchwork.ozlabs.org>); Mon, 18 Oct 2021 04:04:29 -0400 Received: from mail-eopbgr1310139.outbound.protection.outlook.com ([40.107.131.139]:1589 "EHLO APC01-SG2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S230525AbhJRIEC (ORCPT <rfc822;linux-tegra@vger.kernel.org>); Mon, 18 Oct 2021 04:04:02 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ir3w5SSoSqWvXy9el+anYf3jpMxYL6mommQmIY5Sw5p7ft3prFwjfFogfoPEUrgJjLAdT30nCHVrb8u3IGhJdPPJkbnh53EFW5OXsVg/y4sCfzm8r99u44h0d4XMO7cGUEz8kBwpd5J+2erasXRH5WJbrpsASYtrGkHxRyitK3f9yT8nXJnA1RaTrjlypzVFtK9IjQATy+gAeX7FpiB1CECgRVDM4h7hn9lktG6Dw7xmFxMughgMkYt5tJMAaOOhPhED5cEY6g85TkXuJQQ9CORU+5vJWKJ6efPD9ftDxatrLFfLErQRMyY6WrcyyPH98++Nk2P+JqHowBDJRsc3Kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7N5ohZGvjJi3k+WmKw4uI+z/e0NY311QI1EOE7jz2Gg=; b=Q+UVyBJYqWASOpOhgznM2xakPgc5OXCTSlnVyA68nRsShbntKacmud6sz8CMpl++oI3QvcEWhHiD1sMEW0dRfFtgTMN7RQiHD7DlWtf+Uv+xKiO8kBLX00bWwyHqki3UJ7itLzmJ9Vj9tCGqBiKW+K9EFpN3tjBD5LuIL/k3dZXPuY3RUqKyIxh7nmQW1U/MQXOw7ONj6DjUTQOI6JeP6IET5/7/qpgXGymbVEm2aWDI1RqnOXWIvyY+CZk8C8yGQ5m+rNnH0+PgLI/29/cp2icnOPWVpuVgo1WeRrFBw3lVfyvSY2BGGp9Tqk0mHgmm7/qftXRYtPxZav2QgDluGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo0.onmicrosoft.com; s=selector2-vivo0-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7N5ohZGvjJi3k+WmKw4uI+z/e0NY311QI1EOE7jz2Gg=; b=eBOYHLyYOwkxGdZXm09ZAi0zHs6bHeX6b3R/kS2lgEEqs4RsqwsAV6t2wv7x4eSLALTR2VtWFNh/nOmMDFloyIB1n4QLfrHXma/EVhJZ6Ysf2yW7pniSvme7EK2uHJw3VT8kMFA1Z21a2xgw7GNVPqj7X+2XDlcIyqGSyIewcIg= Authentication-Results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=vivo.com; Received: from SL2PR06MB3082.apcprd06.prod.outlook.com (2603:1096:100:37::17) by SL2PR06MB3387.apcprd06.prod.outlook.com (2603:1096:100:3d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14; Mon, 18 Oct 2021 08:00:30 +0000 Received: from SL2PR06MB3082.apcprd06.prod.outlook.com ([fe80::4c9b:b71f:fb67:6414]) by SL2PR06MB3082.apcprd06.prod.outlook.com ([fe80::4c9b:b71f:fb67:6414%6]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021 08:00:30 +0000 From: Qing Wang <wangqing@vivo.com> To: Thierry Reding <thierry.reding@gmail.com>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Jonathan Hunter <jonathanh@nvidia.com>, dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Qing Wang <wangqing@vivo.com> Subject: [PATCH] gpu: drm: tegra: switch over to vmemdup_user() Date: Mon, 18 Oct 2021 01:00:19 -0700 Message-Id: <1634544019-36822-1-git-send-email-wangqing@vivo.com> X-Mailer: git-send-email 2.7.4 Content-Type: text/plain X-ClientProxiedBy: SG2PR01CA0145.apcprd01.prod.exchangelabs.com (2603:1096:4:8f::25) To SL2PR06MB3082.apcprd06.prod.outlook.com (2603:1096:100:37::17) MIME-Version: 1.0 Received: from ubuntu.localdomain (218.213.202.189) by SG2PR01CA0145.apcprd01.prod.exchangelabs.com (2603:1096:4:8f::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.4608.18 via Frontend Transport; Mon, 18 Oct 2021 08:00:28 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7f682449-3069-4294-a144-08d9920d5abf X-MS-TrafficTypeDiagnostic: SL2PR06MB3387: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: <SL2PR06MB33877AB14D7276796E7F6843BDBC9@SL2PR06MB3387.apcprd06.prod.outlook.com> X-MS-Oob-TLC-OOBClassifiers: OLM:2657; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UMOMXQvfCpBjbalKpEHpuuu6nqRs9SlkzonzLTos5WGCCqhdpJ4srnzyOdJ5ZXL5U20aRlhnJK29B0KUyWfRMip2/8YdrBRN4dTeoXxg5yTzJlCRkE5s69lfKsSlsfufiBTBPovFIfwIPwAOJcYbagGazAWlegrEIkkh7JiN9oZKRM/QQyV4FDioTWKdGaWpD+apsS6mIW1DFpJIfMYR3EsnDTBHU2uUfOyzSiFaWreD7vhM2Uc8VTfquNchYQSUzV+2cNUjchQqDbknzgFbMtZb2LRDZ7qQo7K8+wEi29mcuYGMbITJoARUWwEipQBTqVtNvbdbKXoEQ/jRqtE2YAcrN/dWzxlAK9PnI6W7q+fZ74/j56BaVkpQuLPFTrlt8XdtmQcK+89QfaL/G/CAtm4eTYFPL1S+PgIT3DWbB0y7bEz7PLKckhE6tizNlCH6zR2uwVL1xPz2ujYQhdSppmpa05S+yB1W9rSh0ZSJKh6KfN63MXlg+t0DboSAmbCy28mf3h2XN65wo3TU1vaRO7TVhoEH1WEr6BS5g4EAPI/tI8h5vJ87jwU9wtqw5zFdlLycQxB15soTUgvrrM5s+9QJQh8ghbitX9axbSnta3JH0lPl2adm90hmjhVgvBNAgCpIGZr5TucSDECjBZfF1g+T0I1NFumk2C1kOCdDSKFtScm+CbP8cxY9ZL5YGsFoWlT6VaRcVMdKW+OKAB3mTA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SL2PR06MB3082.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(508600001)(6512007)(6506007)(26005)(6486002)(86362001)(8936002)(66556008)(66476007)(66946007)(107886003)(2616005)(956004)(6666004)(316002)(5660300002)(110136005)(2906002)(36756003)(83380400001)(52116002)(38100700002)(4326008)(38350700002)(8676002)(186003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 5BWaxM9B6IR9gcTGeIfRQDJAmkE/Z1NyQvzmd51uP0oDAzp1yXUC1pn0RZf3tkcHgsRsAOMeKLUCqiJ3lliCk5XdCi+l7QEaDF4ZtlP+5pXuZQJzd1O/OxT7XweVVhfdqJD6Yki+DcTzHQD09umliKUXRwFWVhUEZsUCI/1YtJIOGruiYUpfcLmtwjmHk77ZbKCdZN9zV/oxoheJw/BTxsthYYKLxdhYk1ohlaYBALUR6q5ENdx16wONUp/j5eluDzg/hduWFyC/uC0fi0ZoxVJ5sMWFl5Zo/b2ridN2vOl0x6tqpavSYH/FeBbMhMbFZznbEWg7jdF+o4OGfhhna65Z5UeQl5nl/9ogzzDYanLQ/CS4porOHX0VORRHgZWIdTwBy94RTO8lJXnOon1MDlqPInGz3EGvdYZUi9WsK8C2BdcL7mjokHx5canfLou1IYx0Bu7R4RV2qCD8MhygWZ3j409Ed+2jBIDKE+pg/Tc8nN0oCmmnXuACjgdY4HtQjjbNv7OAH4q0aBifongXY7AYtAAj9MORLSPVxz+vdHc44LguHy+MordLYv/wEGuEIIvDgUYnfELj8nCaQfwDo+ahVYNb4ljcsNhhjkH9qRpQe2OpFw6ZdY8725Ptef3hv/3GF1TTbjoAXEMxolyEN3uniaGHsRkBsWekpGuDv2jKnqEiWJMQj7F5GX9Suj+owYGb936yVA1JzFxnhz+SFPbqs0OvJbZi+uFuX1MYPeLJAEO+xjjN7embcahDi/p0Vp9RURmoGd3wAZhBGgl6IJYKgnb9fo3PiczlcUfc1C5Xa2gQg49A6wuFeMtazi/vsvfykAYxPMrSKrG/TxzmjWxKzfhc6dVN6GOFcWTjcR/AblexTnvx/mbgfcyb9LeWPAt3cFHdkb8dA1GECDMXElcHHdpDREGRErQLnc/my3gTroDIQ99bOtxRnyHhA+Q07HPdUsN/UnIb5PIKo62rt9acFAcLx8Cse2TstGRHAHYNurII3vyufjoPXFRYX+2kp84yGLoqIIYlNAnVwqd2ChFmNg0Kg1PIM28nFTm4e0isWPnHyMG8phauycln7CJtg7M7BCKuC1eDfLtPJpRBs2QB/N80iMsNN5pg62XSwbPwnr6AkgVSOXzBSWg1Jd+l4mQ7+Cd09Ewx1zpaPiH2nN8/kvJZz7/trfKxzqQmu4ufPHnHshi4PUFXSD2JfCNts4Auikmb8I5VCb6IXQ82xM097ykyAojsuKkURpCpIrch9J2JDbO0vaMOZDzlYZfwMA2vJh48XWFJUtVwwW4p1Pu6ihuCZvrK+E5rizOd2vob5zHv9RqdR2/WunYQCpaD X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7f682449-3069-4294-a144-08d9920d5abf X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 08:00:30.7242 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qA08X/2HPxbukceuBN+i0dtWuRqV3ksj6EIzmFeLM+cnJbohh4PWYL0ToZDdC1CKCkaNasu0amrakESuCKt85g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SL2PR06MB3387 Precedence: bulk List-ID: <linux-tegra.vger.kernel.org> X-Mailing-List: linux-tegra@vger.kernel.org |
Series |
gpu: drm: tegra: switch over to vmemdup_user()
|
expand
|
diff --git a/drivers/gpu/drm/tegra/submit.c b/drivers/gpu/drm/tegra/submit.c index c326984..0b11f1a --- a/drivers/gpu/drm/tegra/submit.c +++ b/drivers/gpu/drm/tegra/submit.c @@ -169,14 +169,9 @@ static void *alloc_copy_user_array(void __user *from, size_t count, size_t size) if (copy_len > 0x4000) return ERR_PTR(-E2BIG); - data = kvmalloc(copy_len, GFP_KERNEL); - if (!data) - return ERR_PTR(-ENOMEM); - - if (copy_from_user(data, from, copy_len)) { - kvfree(data); - return ERR_PTR(-EFAULT); - } + data = vmemdup_user(from, copy_len); + if (IS_ERR(data)) + return ERR_PTR(PTR_ERR(data)); return data; }
This patch fixes the following Coccinelle warning: drivers/gpu/drm/tegra/submit.c:173:8-15: WARNING \ opportunity for vmemdup_user Use vmemdup_user rather than duplicating its implementation This is a little bit restricted to reduce false positives Signed-off-by: Qing Wang <wangqing@vivo.com> --- drivers/gpu/drm/tegra/submit.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-)