| Message ID | 1614243958-55847-1-git-send-email-yang.lee@linux.alibaba.com |
|---|---|
| State | Rejected |
| Headers | show |
| Series | memory: tegra: Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE | expand |
On Thu, Feb 25, 2021 at 05:05:58PM +0800, Yang Li wrote: > Fix the following coccicheck warning: > ./drivers/memory/tegra/tegra124-emc.c:1207:0-23: WARNING: > tegra_emc_debug_min_rate_fops should be defined with > DEFINE_DEBUGFS_ATTRIBUTE > ./drivers/memory/tegra/tegra124-emc.c:1237:0-23: WARNING: > tegra_emc_debug_max_rate_fops should be defined with > DEFINE_DEBUGFS_ATTRIBUTE > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > --- > drivers/memory/tegra/tegra124-emc.c | 4 ++-- Thanks, applied. Best regards, Krzysztof
diff --git a/drivers/memory/tegra/tegra124-emc.c b/drivers/memory/tegra/tegra124-emc.c index bee8d9f..874e1a0 100644 --- a/drivers/memory/tegra/tegra124-emc.c +++ b/drivers/memory/tegra/tegra124-emc.c @@ -1204,7 +1204,7 @@ static int tegra_emc_debug_min_rate_set(void *data, u64 rate) return 0; } -DEFINE_SIMPLE_ATTRIBUTE(tegra_emc_debug_min_rate_fops, +DEFINE_DEBUGFS_ATTRIBUTE(tegra_emc_debug_min_rate_fops, tegra_emc_debug_min_rate_get, tegra_emc_debug_min_rate_set, "%llu\n"); @@ -1234,7 +1234,7 @@ static int tegra_emc_debug_max_rate_set(void *data, u64 rate) return 0; } -DEFINE_SIMPLE_ATTRIBUTE(tegra_emc_debug_max_rate_fops, +DEFINE_DEBUGFS_ATTRIBUTE(tegra_emc_debug_max_rate_fops, tegra_emc_debug_max_rate_get, tegra_emc_debug_max_rate_set, "%llu\n");
Fix the following coccicheck warning: ./drivers/memory/tegra/tegra124-emc.c:1207:0-23: WARNING: tegra_emc_debug_min_rate_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE ./drivers/memory/tegra/tegra124-emc.c:1237:0-23: WARNING: tegra_emc_debug_max_rate_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/memory/tegra/tegra124-emc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)