| Message ID | 1559908507-31192-2-git-send-email-bbiswas@nvidia.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [V1,1/6] i2c: tegra: clean up macros | expand |
07.06.2019 14:55, Bitan Biswas пишет: > Remove variable initializations in functions that > are followed by assignments before use > > Signed-off-by: Bitan Biswas <bbiswas@nvidia.com> > --- > drivers/i2c/busses/i2c-tegra.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c > index 00692d8..f7116b7 100644 > --- a/drivers/i2c/busses/i2c-tegra.c > +++ b/drivers/i2c/busses/i2c-tegra.c > @@ -689,7 +689,7 @@ static int tegra_i2c_init(struct tegra_i2c_dev *i2c_dev, bool clk_reinit) > u32 val; > int err; > u32 clk_divisor, clk_multiplier; > - u32 tsu_thd = 0; > + u32 tsu_thd; > u8 tlow, thigh; > > err = pm_runtime_get_sync(i2c_dev->dev); > @@ -1218,7 +1218,7 @@ static int tegra_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[], > { > struct tegra_i2c_dev *i2c_dev = i2c_get_adapdata(adap); > int i; > - int ret = 0; > + int ret; > > ret = pm_runtime_get_sync(i2c_dev->dev); > if (ret < 0) { > @@ -1489,7 +1489,7 @@ static int tegra_i2c_probe(struct platform_device *pdev) > void __iomem *base; > phys_addr_t base_phys; > int irq; > - int ret = 0; > + int ret; > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > base_phys = res->start; > Thanks! Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index 00692d8..f7116b7 100644 --- a/drivers/i2c/busses/i2c-tegra.c +++ b/drivers/i2c/busses/i2c-tegra.c @@ -689,7 +689,7 @@ static int tegra_i2c_init(struct tegra_i2c_dev *i2c_dev, bool clk_reinit) u32 val; int err; u32 clk_divisor, clk_multiplier; - u32 tsu_thd = 0; + u32 tsu_thd; u8 tlow, thigh; err = pm_runtime_get_sync(i2c_dev->dev); @@ -1218,7 +1218,7 @@ static int tegra_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[], { struct tegra_i2c_dev *i2c_dev = i2c_get_adapdata(adap); int i; - int ret = 0; + int ret; ret = pm_runtime_get_sync(i2c_dev->dev); if (ret < 0) { @@ -1489,7 +1489,7 @@ static int tegra_i2c_probe(struct platform_device *pdev) void __iomem *base; phys_addr_t base_phys; int irq; - int ret = 0; + int ret; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); base_phys = res->start;
Remove variable initializations in functions that are followed by assignments before use Signed-off-by: Bitan Biswas <bbiswas@nvidia.com> --- drivers/i2c/busses/i2c-tegra.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)