| Message ID | 1548073731-6449-5-git-send-email-talho@nvidia.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | add Tegra210 BPMP driver | expand |
On Mon, 21 Jan 2019 14:28:51 +0200, Timo Alho wrote: > The BPMP is a specific processor in Tegra210 chip, which is designed > for boot process handling, assisting in entering deep low power states > (suspend to ram), and offloading DRAM memory clock scaling on some > platforms. > > Signed-off-by: Timo Alho <talho@nvidia.com> > --- > .../bindings/firmware/nvidia,tegra210-bpmp.txt | 36 ++++++++++++++++++++++ > 1 file changed, 36 insertions(+) > create mode 100644 Documentation/devicetree/bindings/firmware/nvidia,tegra210-bpmp.txt > Reviewed-by: Rob Herring <robh@kernel.org>
On 21/01/2019 12:28, Timo Alho wrote: > The BPMP is a specific processor in Tegra210 chip, which is designed > for boot process handling, assisting in entering deep low power states > (suspend to ram), and offloading DRAM memory clock scaling on some > platforms. > > Signed-off-by: Timo Alho <talho@nvidia.com> > --- > .../bindings/firmware/nvidia,tegra210-bpmp.txt | 36 ++++++++++++++++++++++ > 1 file changed, 36 insertions(+) > create mode 100644 Documentation/devicetree/bindings/firmware/nvidia,tegra210-bpmp.txt > > diff --git a/Documentation/devicetree/bindings/firmware/nvidia,tegra210-bpmp.txt b/Documentation/devicetree/bindings/firmware/nvidia,tegra210-bpmp.txt > new file mode 100644 > index 0000000..63f439a > --- /dev/null > +++ b/Documentation/devicetree/bindings/firmware/nvidia,tegra210-bpmp.txt > @@ -0,0 +1,36 @@ > +NVIDIA Tegra210 Boot and Power Management Processor (BPMP) > + > +The Boot and Power Management Processor (BPMP) is a co-processor found > +in Tegra210 SoC. It is designed to handle the early stages of the boot > +process as well as to assisting in entering deep low power state > +(suspend to ram), and also offloading DRAM memory clock scaling on > +some platforms. The binding document defines the resources that would > +be used by the BPMP T210 firmware driver, which can create the > +interprocessor communication (IPC) between the CPU and BPMP. > + > +Required properties: > +- name : Should be bpmp > +- compatible > + Array of strings > + One of: > + - "nvidia,tegra210-bpmp" > +- reg: physical base address and length for HW synchornization primitives > + 1) base address and length to Tegra 'atomics' hardware > + 2) base address and length to Tegra 'semaphore' hardware > +- interrupts: specifies the interrupt number for receiving messages ("rx") > + and for triggering messages ("tx") > + > +Optional properties: > +- #clock-cells : Should be 1 for platforms where DRAM clock control is > + offloaded to bpmp. > + > +Example: > + > +bpmp@70016000 { > + compatible = "nvidia,tegra210-bpmp"; > + reg = <0x0 0x70016000 0x0 0x2000 > + 0x0 0x60001000 0x0 0x1000>; > + interrupts = <0 6 IRQ_TYPE_NONE>, > + <0 4 IRQ_TYPE_EDGE_RISING>; > + interrupt-names = "tx", "rx"; > +}; Under required properties you have 'name' but it does not feature in the above example. In fact, I see the same for the Tegra186 BPMP binding. Do we actually use/need this name property? Cheers Jon
On 24/01/2019 12:19, Jon Hunter wrote: > > On 21/01/2019 12:28, Timo Alho wrote: >> The BPMP is a specific processor in Tegra210 chip, which is designed >> for boot process handling, assisting in entering deep low power states >> (suspend to ram), and offloading DRAM memory clock scaling on some >> platforms. >> >> Signed-off-by: Timo Alho <talho@nvidia.com> >> --- >> .../bindings/firmware/nvidia,tegra210-bpmp.txt | 36 ++++++++++++++++++++++ >> 1 file changed, 36 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/firmware/nvidia,tegra210-bpmp.txt >> >> diff --git a/Documentation/devicetree/bindings/firmware/nvidia,tegra210-bpmp.txt b/Documentation/devicetree/bindings/firmware/nvidia,tegra210-bpmp.txt >> new file mode 100644 >> index 0000000..63f439a >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/firmware/nvidia,tegra210-bpmp.txt >> @@ -0,0 +1,36 @@ >> +NVIDIA Tegra210 Boot and Power Management Processor (BPMP) >> + >> +The Boot and Power Management Processor (BPMP) is a co-processor found >> +in Tegra210 SoC. It is designed to handle the early stages of the boot >> +process as well as to assisting in entering deep low power state >> +(suspend to ram), and also offloading DRAM memory clock scaling on >> +some platforms. The binding document defines the resources that would >> +be used by the BPMP T210 firmware driver, which can create the >> +interprocessor communication (IPC) between the CPU and BPMP. >> + >> +Required properties: >> +- name : Should be bpmp >> +- compatible >> + Array of strings >> + One of: >> + - "nvidia,tegra210-bpmp" >> +- reg: physical base address and length for HW synchornization primitives >> + 1) base address and length to Tegra 'atomics' hardware >> + 2) base address and length to Tegra 'semaphore' hardware >> +- interrupts: specifies the interrupt number for receiving messages ("rx") >> + and for triggering messages ("tx") >> + >> +Optional properties: >> +- #clock-cells : Should be 1 for platforms where DRAM clock control is >> + offloaded to bpmp. >> + >> +Example: >> + >> +bpmp@70016000 { >> + compatible = "nvidia,tegra210-bpmp"; >> + reg = <0x0 0x70016000 0x0 0x2000 >> + 0x0 0x60001000 0x0 0x1000>; >> + interrupts = <0 6 IRQ_TYPE_NONE>, >> + <0 4 IRQ_TYPE_EDGE_RISING>; >> + interrupt-names = "tx", "rx"; >> +}; > > Under required properties you have 'name' but it does not feature in the > above example. In fact, I see the same for the Tegra186 BPMP binding. > > Do we actually use/need this name property? I am wondering if 'TYPE_NONE' for TX is correct here. I understand that Linux does not request this interrupt, but still shouldn't DT reflect it actual type? Cheers Jon
Hi Jon, On 24.1.2019 15.02, Jon Hunter wrote: > > On 24/01/2019 12:19, Jon Hunter wrote: >> >> On 21/01/2019 12:28, Timo Alho wrote: >>> The BPMP is a specific processor in Tegra210 chip, which is designed >>> for boot process handling, assisting in entering deep low power states >>> (suspend to ram), and offloading DRAM memory clock scaling on some >>> platforms. >>> >>> Signed-off-by: Timo Alho <talho@nvidia.com> >>> --- >>> .../bindings/firmware/nvidia,tegra210-bpmp.txt | 36 ++++++++++++++++++++++ >>> 1 file changed, 36 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/firmware/nvidia,tegra210-bpmp.txt >>> >>> diff --git a/Documentation/devicetree/bindings/firmware/nvidia,tegra210-bpmp.txt b/Documentation/devicetree/bindings/firmware/nvidia,tegra210-bpmp.txt >>> new file mode 100644 >>> index 0000000..63f439a >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/firmware/nvidia,tegra210-bpmp.txt >>> @@ -0,0 +1,36 @@ >>> +NVIDIA Tegra210 Boot and Power Management Processor (BPMP) >>> + >>> +The Boot and Power Management Processor (BPMP) is a co-processor found >>> +in Tegra210 SoC. It is designed to handle the early stages of the boot >>> +process as well as to assisting in entering deep low power state >>> +(suspend to ram), and also offloading DRAM memory clock scaling on >>> +some platforms. The binding document defines the resources that would >>> +be used by the BPMP T210 firmware driver, which can create the >>> +interprocessor communication (IPC) between the CPU and BPMP. >>> + >>> +Required properties: >>> +- name : Should be bpmp >>> +- compatible >>> + Array of strings >>> + One of: >>> + - "nvidia,tegra210-bpmp" >>> +- reg: physical base address and length for HW synchornization primitives >>> + 1) base address and length to Tegra 'atomics' hardware >>> + 2) base address and length to Tegra 'semaphore' hardware >>> +- interrupts: specifies the interrupt number for receiving messages ("rx") >>> + and for triggering messages ("tx") >>> + >>> +Optional properties: >>> +- #clock-cells : Should be 1 for platforms where DRAM clock control is >>> + offloaded to bpmp. >>> + >>> +Example: >>> + >>> +bpmp@70016000 { >>> + compatible = "nvidia,tegra210-bpmp"; >>> + reg = <0x0 0x70016000 0x0 0x2000 >>> + 0x0 0x60001000 0x0 0x1000>; >>> + interrupts = <0 6 IRQ_TYPE_NONE>, >>> + <0 4 IRQ_TYPE_EDGE_RISING>; >>> + interrupt-names = "tx", "rx"; >>> +}; >> >> Under required properties you have 'name' but it does not feature in the >> above example. In fact, I see the same for the Tegra186 BPMP binding. >> >> Do we actually use/need this name property? > > I am wondering if 'TYPE_NONE' for TX is correct here. I understand that > Linux does not request this interrupt, but still shouldn't DT reflect it > actual type? Makes sense, I'll update. And while at it, I'll just change '0' to 'GIC_SPI' to have it corrected as well. > Cheers > Jon > BR, Timo
diff --git a/Documentation/devicetree/bindings/firmware/nvidia,tegra210-bpmp.txt b/Documentation/devicetree/bindings/firmware/nvidia,tegra210-bpmp.txt new file mode 100644 index 0000000..63f439a --- /dev/null +++ b/Documentation/devicetree/bindings/firmware/nvidia,tegra210-bpmp.txt @@ -0,0 +1,36 @@ +NVIDIA Tegra210 Boot and Power Management Processor (BPMP) + +The Boot and Power Management Processor (BPMP) is a co-processor found +in Tegra210 SoC. It is designed to handle the early stages of the boot +process as well as to assisting in entering deep low power state +(suspend to ram), and also offloading DRAM memory clock scaling on +some platforms. The binding document defines the resources that would +be used by the BPMP T210 firmware driver, which can create the +interprocessor communication (IPC) between the CPU and BPMP. + +Required properties: +- name : Should be bpmp +- compatible + Array of strings + One of: + - "nvidia,tegra210-bpmp" +- reg: physical base address and length for HW synchornization primitives + 1) base address and length to Tegra 'atomics' hardware + 2) base address and length to Tegra 'semaphore' hardware +- interrupts: specifies the interrupt number for receiving messages ("rx") + and for triggering messages ("tx") + +Optional properties: +- #clock-cells : Should be 1 for platforms where DRAM clock control is + offloaded to bpmp. + +Example: + +bpmp@70016000 { + compatible = "nvidia,tegra210-bpmp"; + reg = <0x0 0x70016000 0x0 0x2000 + 0x0 0x60001000 0x0 0x1000>; + interrupts = <0 6 IRQ_TYPE_NONE>, + <0 4 IRQ_TYPE_EDGE_RISING>; + interrupt-names = "tx", "rx"; +};
The BPMP is a specific processor in Tegra210 chip, which is designed for boot process handling, assisting in entering deep low power states (suspend to ram), and offloading DRAM memory clock scaling on some platforms. Signed-off-by: Timo Alho <talho@nvidia.com> --- .../bindings/firmware/nvidia,tegra210-bpmp.txt | 36 ++++++++++++++++++++++ 1 file changed, 36 insertions(+) create mode 100644 Documentation/devicetree/bindings/firmware/nvidia,tegra210-bpmp.txt