| Message ID | 1543383877-20555-2-git-send-email-wni@nvidia.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Fixes for Tegra soctherm | expand |
On Wed, Nov 28, 2018 at 01:44:35PM +0800, Wei Ni wrote: > Convert warnings to info as not all platforms may > have all the thresholds and sensors enabled. > > Signed-off-by: Wei Ni <wni@nvidia.com> > --- > drivers/thermal/tegra/soctherm.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) If these are all optional anyway, why even keep the informational messages? While those may not show up as warnings in the log, they will still be unconditional noise in the kernel log. Do we really want that, or should we just trust that the DT is correct and shut up if optional thresholds and sensors are not present? Thierry
On 28/11/2018 6:12 PM, Thierry Reding wrote: > On Wed, Nov 28, 2018 at 01:44:35PM +0800, Wei Ni wrote: >> Convert warnings to info as not all platforms may >> have all the thresholds and sensors enabled. >> >> Signed-off-by: Wei Ni <wni@nvidia.com> >> --- >> drivers/thermal/tegra/soctherm.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) > > If these are all optional anyway, why even keep the informational > messages? While those may not show up as warnings in the log, they will > still be unconditional noise in the kernel log. Do we really want that, > or should we just trust that the DT is correct and shut up if optional > thresholds and sensors are not present? > > Thierry I think we can trust the DT files, but these trip points are important, it's better to notify user about these information. And user also can change log level to control these messages. Thanks. Wei. >
diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c index ed28110a3535..55cc1f2f6a45 100644 --- a/drivers/thermal/tegra/soctherm.c +++ b/drivers/thermal/tegra/soctherm.c @@ -550,7 +550,7 @@ static int tegra_soctherm_set_hwtrips(struct device *dev, ret = tz->ops->get_crit_temp(tz, &temperature); if (ret) { - dev_warn(dev, "thermtrip: %s: missing critical temperature\n", + dev_info(dev, "thermtrip: %s: missing critical temperature\n", sg->name); goto set_throttle; } @@ -569,7 +569,7 @@ static int tegra_soctherm_set_hwtrips(struct device *dev, set_throttle: ret = get_hot_temp(tz, &trip, &temperature); if (ret) { - dev_warn(dev, "throttrip: %s: missing hot temperature\n", + dev_info(dev, "throttrip: %s: missing hot temperature\n", sg->name); return 0; } @@ -600,7 +600,7 @@ static int tegra_soctherm_set_hwtrips(struct device *dev, } if (i == THROTTLE_SIZE) - dev_warn(dev, "throttrip: %s: missing throttle cdev\n", + dev_info(dev, "throttrip: %s: missing throttle cdev\n", sg->name); return 0;
Convert warnings to info as not all platforms may have all the thresholds and sensors enabled. Signed-off-by: Wei Ni <wni@nvidia.com> --- drivers/thermal/tegra/soctherm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)