| Message ID | 1470134069-12178-5-git-send-email-jonathanh@nvidia.com |
|---|---|
| State | Rejected |
| Delegated to: | Thierry Reding |
| Headers | show |
On Tue, Aug 02, 2016 at 11:34:29AM +0100, Jon Hunter wrote: > Add the clock and reset names for the Tegra210 Audio powergate. Please > note that these are not currently used, but added from completeness and > to be consistent with the other powergate nodes. > > Signed-off-by: Jon Hunter <jonathanh@nvidia.com> > --- > > We added the clock and resets names for the XUSB partitions and so I > thought we should do the same for the Audio. Should I update the binding > documentation to say these should be provided? Currently it does not > state these are required. If we do update the binding doc, I was not > entirely sure what to put in the description for these properties. > Typically the clock and reset names would be fixed for a device, but here > we are not using them and so there are no fixed names. The names are there for the consumer's benefit, so if the consumer binding doesn't require specific names, they shouldn't be in the DT. It doesn't make sense to have names which are not fixed from the consumer's PoV, so if anything the above is an argument for *removing* the unnecessary and varied names from other nodes. Thanks, Mark. > > arch/arm64/boot/dts/nvidia/tegra210.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/nvidia/tegra210.dtsi b/arch/arm64/boot/dts/nvidia/tegra210.dtsi > index c4cfdcf60d26..92e987acc551 100644 > --- a/arch/arm64/boot/dts/nvidia/tegra210.dtsi > +++ b/arch/arm64/boot/dts/nvidia/tegra210.dtsi > @@ -644,7 +644,9 @@ > pd_audio: aud { > clocks = <&tegra_car TEGRA210_CLK_APE>, > <&tegra_car TEGRA210_CLK_APB2APE>; > + clock-names = "ape", "apb2ape"; > resets = <&tegra_car 198>; > + reset-names = "ape"; > #power-domain-cells = <0>; > }; > > -- > 2.1.4 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 02/08/16 15:18, Mark Rutland wrote: > On Tue, Aug 02, 2016 at 11:34:29AM +0100, Jon Hunter wrote: >> Add the clock and reset names for the Tegra210 Audio powergate. Please >> note that these are not currently used, but added from completeness and >> to be consistent with the other powergate nodes. >> >> Signed-off-by: Jon Hunter <jonathanh@nvidia.com> >> --- >> >> We added the clock and resets names for the XUSB partitions and so I >> thought we should do the same for the Audio. Should I update the binding >> documentation to say these should be provided? Currently it does not >> state these are required. If we do update the binding doc, I was not >> entirely sure what to put in the description for these properties. >> Typically the clock and reset names would be fixed for a device, but here >> we are not using them and so there are no fixed names. > > The names are there for the consumer's benefit, so if the consumer > binding doesn't require specific names, they shouldn't be in the DT. > It doesn't make sense to have names which are not fixed from the > consumer's PoV, so if anything the above is an argument for *removing* > the unnecessary and varied names from other nodes. Yes I was not sure if this correct. We could always add the names at a later stage if they are needed. Thierry, do you still want to have the names present? If not, then I can remove those for xusb. Cheers Jon
On Tue, Aug 02, 2016 at 07:43:41PM +0100, Jon Hunter wrote: > > On 02/08/16 15:18, Mark Rutland wrote: > > On Tue, Aug 02, 2016 at 11:34:29AM +0100, Jon Hunter wrote: > >> Add the clock and reset names for the Tegra210 Audio powergate. Please > >> note that these are not currently used, but added from completeness and > >> to be consistent with the other powergate nodes. > >> > >> Signed-off-by: Jon Hunter <jonathanh@nvidia.com> > >> --- > >> > >> We added the clock and resets names for the XUSB partitions and so I > >> thought we should do the same for the Audio. Should I update the binding > >> documentation to say these should be provided? Currently it does not > >> state these are required. If we do update the binding doc, I was not > >> entirely sure what to put in the description for these properties. > >> Typically the clock and reset names would be fixed for a device, but here > >> we are not using them and so there are no fixed names. > > > > The names are there for the consumer's benefit, so if the consumer > > binding doesn't require specific names, they shouldn't be in the DT. > > It doesn't make sense to have names which are not fixed from the > > consumer's PoV, so if anything the above is an argument for *removing* > > the unnecessary and varied names from other nodes. > > Yes I was not sure if this correct. We could always add the names at a > later stage if they are needed. > > Thierry, do you still want to have the names present? If not, then I can > remove those for xusb. I would've liked to keep this consistent with other nodes, but as Mark pointed out the power domain case is somewhat special in that the names or any ordering are completely irrelevant. Let's drop this one and remove the clock and reset names from the XUSB power domains as well. Thierry
diff --git a/arch/arm64/boot/dts/nvidia/tegra210.dtsi b/arch/arm64/boot/dts/nvidia/tegra210.dtsi index c4cfdcf60d26..92e987acc551 100644 --- a/arch/arm64/boot/dts/nvidia/tegra210.dtsi +++ b/arch/arm64/boot/dts/nvidia/tegra210.dtsi @@ -644,7 +644,9 @@ pd_audio: aud { clocks = <&tegra_car TEGRA210_CLK_APE>, <&tegra_car TEGRA210_CLK_APB2APE>; + clock-names = "ape", "apb2ape"; resets = <&tegra_car 198>; + reset-names = "ape"; #power-domain-cells = <0>; };
Add the clock and reset names for the Tegra210 Audio powergate. Please note that these are not currently used, but added from completeness and to be consistent with the other powergate nodes. Signed-off-by: Jon Hunter <jonathanh@nvidia.com> --- We added the clock and resets names for the XUSB partitions and so I thought we should do the same for the Audio. Should I update the binding documentation to say these should be provided? Currently it does not state these are required. If we do update the binding doc, I was not entirely sure what to put in the description for these properties. Typically the clock and reset names would be fixed for a device, but here we are not using them and so there are no fixed names. arch/arm64/boot/dts/nvidia/tegra210.dtsi | 2 ++ 1 file changed, 2 insertions(+)